Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parents to orphaned terms #2988

Merged
merged 2 commits into from
Jul 26, 2023
Merged

Add parents to orphaned terms #2988

merged 2 commits into from
Jul 26, 2023

Conversation

shawntanzk
Copy link
Collaborator

Fixes #2987

Did not do much digging/research, just adding basic parents, more precise parentage can come in another PR if needed

@shawntanzk shawntanzk self-assigned this Jul 26, 2023
Copy link
Collaborator

@aleixpuigb aleixpuigb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, consider a different parent for pulmonary acinus.

@aleixpuigb
Copy link
Collaborator

aleixpuigb commented Jul 26, 2023

I have received a notification of this commit 14dd3a6, but I can't see it in the PR. Something similar happened to #2983. I can see the commit in the branch, but it will not merge if you merge the PR.
image
Any idea why does that happen?

@shawntanzk
Copy link
Collaborator Author

ok a bit confused, hate not having github desktop, but I have committed the requested change to the branch (14dd3a6) but it does not seem to be showing up in the PR - Is there something I am doing wrong?

@shawntanzk
Copy link
Collaborator Author

shawntanzk commented Jul 26, 2023

ok fixed, sync issue apparently, see https://stackoverflow.com/questions/45626986/updating-pull-request-after-review-changes-commit-doesnt-show-up-in-the-pull-re

just needed to edit the PR, "change" the base branch and select master again, and it forces syncing or smth

@shawntanzk shawntanzk merged commit 916f61f into master Jul 26, 2023
1 check passed
@shawntanzk shawntanzk deleted the issue-2987 branch July 26, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

base-file orphans a few terms
3 participants