Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update HBA bridge mappings to nerves to point to nerve roots #3264

Closed
dosumis opened this issue Apr 26, 2024 · 10 comments · Fixed by #3281
Closed

update HBA bridge mappings to nerves to point to nerve roots #3264

dosumis opened this issue Apr 26, 2024 · 10 comments · Fixed by #3281
Assignees

Comments

@dosumis
Copy link
Contributor

dosumis commented Apr 26, 2024

CC @gouttegd - Can you confirm how we should update Allen Brain Atlas bridge files now. (I should probably know this!)

  • We may also need to check whether all ABA terms are being classified as brain region.
@gouttegd
Copy link
Collaborator

All bridge files (including the custom ones like the MBA and DMBA bridges) are updated with a single command:

sh run.sh make refresh-bridges

This is normally done by @anitacaron (as part of the refresh of all external resources) ahead of a release, but can be done anytime by anyone if there’s a need.

@gouttegd
Copy link
Collaborator

Wait, do you mean updating the contents of the bridges?

It depends on the bridge. For the MBA and DMBA bridges, they are entirely managed outside of Uberon, so they should be updated in their respective repositories (https://github.com/brain-bican/mouse_brain_atlas_ontology and https://github.com/brain-bican/developing_mouse_brain_atlas_ontology).

For the HBA, DHBA, and PBA bridges, the source of truth is still the Uberon -edit file, more precisely the cross-references carried by Uberon term.

@gouttegd
Copy link
Collaborator

So for example, Uberon’s hypoglossal nerve (UBERON:0001650) is currently mapped to HBA:9343. To remap the HBA term to Uberon’s hypoglossal nerve root (UBERON:0004675), you need to remove the HBA:9343 cross-reference on UBERON:0001650 and put it on UBERON:0004675 instead.

@dosumis
Copy link
Contributor Author

dosumis commented Apr 27, 2024

@AvolaAmg - can you make these edits to Uberon? Would be good to do soon if poss and work with @aleixpuigb to make an Uberon release as this affects our ability to do PCL updates.
@hkir-dev - can you provide a list of nerve terms in HBA?

@cmungall
Copy link
Member

cmungall commented Apr 29, 2024 via email

@gouttegd
Copy link
Collaborator

This axiom in HBA seems very wrong (or at the very incompatible with Uberon):

cranial nerves SubClassOf part_of some myelencephalic white matter

HBA’s cranial nerves is mapped to the equivalent term in Uberon (UBERON:0001785), which is classified as being part of the peripheral nervous system. And HBA’s myelencephalic whit matter is mapped to Uberon’s white matter of myelencephalon (UBERON:0019262), which (through hindbrain and white matter) is ultimately part of the central nervous system.

@dosumis
Copy link
Contributor Author

dosumis commented Apr 29, 2024

I think you have to read these from the perspective of how the annotated domains relate to each other on a 3D brain. I'll try to pull out an image to post.

@aleixpuigb
Copy link
Collaborator

@AvolaAmg - can you make these edits to Uberon? Would be good to do soon if poss and work with @aleixpuigb to make an Uberon release as this affects our ability to do PCL updates.

@anitacaron is planning to do an Uberon release soon (probably this week). @AvolaAmg, do you need help with this ticket to make sure it gets in this release?

@AvolaAmg
Copy link
Collaborator

AvolaAmg commented May 7, 2024

Hi @aleixpuigb thanks for your offer, I will have a look at this ticket tomorrow first thing and let you know if I need any help.

anitacaron added a commit that referenced this issue Jun 10, 2024
* update HBA bridge mappings to nerves to point to nerve roots

Fixes some #3264

* Update uberon-edit.obo

* Update uberon-edit.obo

* Update merged_import.owl

* revert changes on `merged_import.owl`

* remove GO classification from uberon-edit.obo

---------

Co-authored-by: Anita Caron <anitacaron@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants