Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH Action to post release diff on release PR #3278

Merged
merged 4 commits into from
May 17, 2024
Merged

GH Action to post release diff on release PR #3278

merged 4 commits into from
May 17, 2024

Conversation

anitacaron
Copy link
Collaborator

@anitacaron anitacaron commented May 16, 2024 •
edited
Loading

The same as we have in CL

@anitacaron anitacaron self-assigned this May 16, 2024
@anitacaron anitacaron marked this pull request as draft May 16, 2024 16:03
@anitacaron anitacaron marked this pull request as ready for review May 17, 2024 10:00
@anitacaron anitacaron requested a review from gouttegd as a code owner May 17, 2024 10:00
matentzn
matentzn previously approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didnt think about this deeply, but LGTM!

gouttegd
gouttegd previously approved these changes May 17, 2024
View reviewed changes
Copy link
Collaborator

@gouttegd gouttegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, but please consider updating the actions we are using (and we should also at some point do that for all our workflows).

.github/workflows/post-release-diff.yml Outdated Show resolved Hide resolved
.github/workflows/post-release-diff.yml Outdated Show resolved Hide resolved
@anitacaron anitacaron dismissed stale reviews from gouttegd and matentzn via 786b487 May 17, 2024 10:54
@anitacaron anitacaron merged commit 7c9b04f into master May 17, 2024
1 check failed
@anitacaron
Copy link
Collaborator Author

I cancelled the QC, which was unnecessary for this PR.

@anitacaron anitacaron deleted the post-release-diff branch July 5, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gouttegd gouttegd gouttegd approved these changes

@matentzn matentzn matentzn approved these changes

@aleixpuigb aleixpuigb Awaiting requested review from aleixpuigb

Assignees

@anitacaron anitacaron

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anitacaron @matentzn @gouttegd