Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update HBA bridge mappings to nerves to point to nerve roots #3281

Merged

Conversation

AvolaAmg
Copy link
Collaborator

Fixes some #3264

@hkir-dev see if it fixes the issue on PCL

@AvolaAmg AvolaAmg requested review from dosumis and hkir-dev May 21, 2024 13:44
@AvolaAmg AvolaAmg self-assigned this May 21, 2024
@AvolaAmg AvolaAmg requested a review from anitacaron as a code owner May 21, 2024 13:44
src/ontology/uberon-edit.obo Outdated Show resolved Hide resolved
src/ontology/imports/merged_import.owl Outdated Show resolved Hide resolved
@AvolaAmg AvolaAmg requested a review from anitacaron May 23, 2024 10:39
@hkir-dev
Copy link

I conducted some tests, and these updates resolved the inconsistencies mentioned in issue brain-bican/human_brain_atlas_ontology#2

Copy link

Here's a diff of how these changes impact the classified ontology (on -base file):

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/uberon/uberon-base.owl
  • Version IRI: http://purl.obolibrary.org/obo/uberon/releases/2024-05-24/uberon-base.owl
  • Loaded from: file:/__w/uberon/uberon/src/ontology/uberon-base-main.owl/uberon-base.owl

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/uberon/uberon-base.owl
  • Version IRI: http://purl.obolibrary.org/obo/uberon/releases/2024-05-24/uberon-base.owl
  • Loaded from: file:/__w/uberon/uberon/src/ontology/uberon-base-pr.owl/uberon-base.owl

Ontology imports

Ontology annotations

accessory XI nerve http://purl.obolibrary.org/obo/UBERON_0002019

Removed

accessory nerve root http://purl.obolibrary.org/obo/UBERON_0014615

Added

cranial nerve http://purl.obolibrary.org/obo/UBERON_0001785

Removed

glossopharyngeal nerve http://purl.obolibrary.org/obo/UBERON_0001649

Removed

glossopharyngeal nerve root http://purl.obolibrary.org/obo/UBERON_0019310

Added

hypoglossal nerve http://purl.obolibrary.org/obo/UBERON_0001650

Removed

hypoglossal nerve root http://purl.obolibrary.org/obo/UBERON_0004675

Added

root of cranial nerve http://purl.obolibrary.org/obo/UBERON_0006843

Added

root of vagus nerve http://purl.obolibrary.org/obo/UBERON_0011213

Added

trigeminal nerve http://purl.obolibrary.org/obo/UBERON_0001645

Removed

trigeminal nerve root http://purl.obolibrary.org/obo/UBERON_0004673

Added

vagus nerve http://purl.obolibrary.org/obo/UBERON_0001759

Removed

@anitacaron
Copy link
Collaborator

#gogoeditdiff

Copy link

Here's a diff of your edit file (unreasoned)

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/uberon/core.owl
  • Version IRI: None
  • Loaded from: file:/__w/uberon/uberon/master/src/ontology/uberon-edit.obo

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/uberon/core.owl
  • Version IRI: None
  • Loaded from: file:/__w/uberon/uberon/branch/src/ontology/uberon-edit.obo

Ontology imports

Ontology annotations

accessory XI nerve http://purl.obolibrary.org/obo/UBERON_0002019

Removed

accessory nerve root http://purl.obolibrary.org/obo/UBERON_0014615

Added

cranial nerve http://purl.obolibrary.org/obo/UBERON_0001785

Removed

glossopharyngeal nerve http://purl.obolibrary.org/obo/UBERON_0001649

Removed

glossopharyngeal nerve root http://purl.obolibrary.org/obo/UBERON_0019310

Added

hypoglossal nerve http://purl.obolibrary.org/obo/UBERON_0001650

Removed

hypoglossal nerve root http://purl.obolibrary.org/obo/UBERON_0004675

Added

root of cranial nerve http://purl.obolibrary.org/obo/UBERON_0006843

Added

root of vagus nerve http://purl.obolibrary.org/obo/UBERON_0011213

Added

trigeminal nerve http://purl.obolibrary.org/obo/UBERON_0001645

Removed

trigeminal nerve root http://purl.obolibrary.org/obo/UBERON_0004673

Added

vagus nerve http://purl.obolibrary.org/obo/UBERON_0001759

Removed

@anitacaron anitacaron linked an issue Jun 10, 2024 that may be closed by this pull request
@anitacaron
Copy link
Collaborator

I'll merge it because Alida is away, and we need a UBERON release soon.

@anitacaron anitacaron merged commit 86f815a into master Jun 10, 2024
1 check passed
@anitacaron anitacaron deleted the update-HBA-bridge-mappings-to-nerves-to-point-to-nerve-roots branch July 5, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update HBA bridge mappings to nerves to point to nerve roots
3 participants