Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lip should be part of face #3311

Closed
aleixpuigb opened this issue Jul 15, 2024 · 3 comments · Fixed by #3312
Closed

Lip should be part of face #3311

aleixpuigb opened this issue Jul 15, 2024 · 3 comments · Fixed by #3312

Comments

@aleixpuigb
Copy link
Collaborator

Uberon term
lip

Suggested revision and reasons
Lip is part of mouth, but not part of face.

@rays22
Copy link
Collaborator

rays22 commented Jul 15, 2024

Consider dropping the 'face 'has part' some mouth' assertion (asserted for UBERON:0001456).
See discussion the discussion here.

@aleixpuigb aleixpuigb changed the title Lip is not part of face Lip should be part of face Jul 16, 2024
@uberon
Copy link

uberon commented Jul 25, 2024 via email

@rays22
Copy link
Collaborator

rays22 commented Jul 29, 2024

Why?

The Suggested revision and reasons should actually read:

Lip is part of mouth, and it should be also part of face.
The reason is to prevent inferring (transitively) that 'lingual tonsil' is part of 'face'.

See obophenotype/upheno#957 (comment)

The changes implemented in the associated PR are as follows

  1. UBERON:0001833 lip
    • 'lip' remains part of 'mouth'
    • in the associated PR 'lip' becomes also part of 'face'
[Term]
id: UBERON:0001833
name: lip
...
relationship: part_of UBERON:0000165 {source="BTO", source="FMA-implicit", source="VHOG", source="ZFA"} ! mouth
+relationship: part_of UBERON:0001456 ! face
...
  1. 'face' no longer 'has part' 'mouth' in the associated PR
id: UBERON:0001456
name: face
...
- relationship: has_part UBERON:0000165 ! mouth
...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants