-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ethmoidal veins #3348
Add ethmoidal veins #3348
Conversation
requested by HUBMap.
related to the anatomical cavity of ethmoid sinus.
…ethmoidal_vein Fix a typo in the text definition.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve although I had two doubts:
- 'ethmoidal vein' part_of 'ethmoidal region': I am not completely sure that the entirety of the vein is in the ethmoidal region, although the images are not 100% clear and it could be.
- I have found a couple of sources that stated that the posterior ethmoidal vein tributes to a different vein than the superior ophtalmic vein (https://doi.org/10.1167/iovs.02-0865, https://doi.org/10.1007/978-3-031-40697-3_23), perhaps the cavernous sinus. However it was not clear and other sources support that it tributes into the SOV.
…ethmoidal_vein Fix location of ethmoidal vein
Thanks @aleixpuigb for your comments.
OK, I have changed 'ethmoid region' to the broader term 'face', where 'face' is meant to be a subdivision of the head, and it includes deeper structures under the visible surface.
OK, I have updated the superior ophthalmic vein tributary. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve this PR.
We have discussed on slack if 'ethmoidal vein' should be part of the face, similar to 'sublingual vein'. It has been discussed before about what structures are part of the face #3310 and Uberon ontology calls.
Now the ethmoid vein is asserted to be part of the vasculature of head, instead of face.
Just to be on the safe side, I have changed the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good, thanks!
requested by HUBMap (HRA-VCCF).