Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3329 unsat for ZFA mapping #3330

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Conversation

aleixpuigb
Copy link
Collaborator

Fixes #3329 unsat for ZFA mapping

parallel fiber, teleost SubClassOf only in taxon some teleost fish
This axiom was not correct, since "teleost fish" is a subclass of 'unclassified Teleostei', a SubclassOf 'Teleostei'. All classified Teleostei also have parallel fibers, and ZFA is using for Danio, a Osteoglossocephalai.
in taxon some Osteoglossocephalai DisjointWith in taxon some unclassified Teleostei
image
image

Fixes #3329 unsat for ZFA mapping
parallel fiber, teleost SubClassOf only in taxon some teleost fish
This axiom was not correct, since "teleost fish" is a subclass of 'unclassified Teleostei', a SubclassOf 'Teleostei'.
All classified Teleostei also have parallel fibers.
Copy link
Collaborator

@anitacaron anitacaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this, @aleixpuigb! 🎉

@aleixpuigb aleixpuigb merged commit 88fc7cd into master Aug 6, 2024
1 check passed
@aleixpuigb aleixpuigb deleted the 3329_ZFA_mapping_unsat branch August 6, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New taxslim-disjoint-over-in-taxon.owl is making violation in one ZFA mapping
2 participants