Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ethmoidal veins #3348

Merged
merged 17 commits into from
Aug 30, 2024
Merged

Add ethmoidal veins #3348

merged 17 commits into from
Aug 30, 2024

Conversation

rays22
Copy link
Collaborator

@rays22 rays22 commented Aug 28, 2024

requested by HUBMap (HRA-VCCF).

requested by HUBMap.
@rays22 rays22 self-assigned this Aug 28, 2024
@rays22 rays22 marked this pull request as draft August 28, 2024 17:28
related to the anatomical cavity of ethmoid sinus.
@rays22 rays22 requested review from aleixpuigb and removed request for anitacaron August 28, 2024 18:20
@rays22 rays22 marked this pull request as ready for review August 28, 2024 18:20
aleixpuigb
aleixpuigb previously approved these changes Aug 29, 2024
Copy link
Collaborator

@aleixpuigb aleixpuigb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve although I had two doubts:

  • 'ethmoidal vein' part_of 'ethmoidal region': I am not completely sure that the entirety of the vein is in the ethmoidal region, although the images are not 100% clear and it could be.
    image
  • I have found a couple of sources that stated that the posterior ethmoidal vein tributes to a different vein than the superior ophtalmic vein (https://doi.org/10.1167/iovs.02-0865, https://doi.org/10.1007/978-3-031-40697-3_23), perhaps the cavernous sinus. However it was not clear and other sources support that it tributes into the SOV.

@rays22
Copy link
Collaborator Author

rays22 commented Aug 29, 2024

Thanks @aleixpuigb for your comments.

I approve although I had two doubts:

  • 'ethmoidal vein' part_of 'ethmoidal region': I am not completely sure that the entirety of the vein is in the ethmoidal region, although the images are not 100% clear and it could be.

OK, I have changed 'ethmoid region' to the broader term 'face', where 'face' is meant to be a subdivision of the head, and it includes deeper structures under the visible surface.

OK, I have updated the superior ophthalmic vein tributary.

@rays22 rays22 requested a review from aleixpuigb August 29, 2024 16:11
aleixpuigb
aleixpuigb previously approved these changes Aug 29, 2024
Copy link
Collaborator

@aleixpuigb aleixpuigb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve this PR.
We have discussed on slack if 'ethmoidal vein' should be part of the face, similar to 'sublingual vein'. It has been discussed before about what structures are part of the face #3310 and Uberon ontology calls.

Now the ethmoid vein is asserted to be part of the vasculature of head, instead of face.
@rays22
Copy link
Collaborator Author

rays22 commented Aug 29, 2024

I approve this PR. We have discussed on slack if 'ethmoidal vein' should be part of the face, similar to 'sublingual vein'. It has been discussed before about what structures are part of the face #3310 and Uberon ontology calls.

Just to be on the safe side, I have changed the location slot for 'ethmoidal vein' to UBERON:0002200 vasculature of head.

@rays22 rays22 requested a review from aleixpuigb August 29, 2024 17:59
Copy link
Collaborator

@aleixpuigb aleixpuigb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good, thanks!

@rays22 rays22 merged commit 6bd5276 into master Aug 30, 2024
1 check passed
@rays22 rays22 deleted the ethmoidal_vein branch August 30, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants