Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incompatibility with ZFA's "head". #3360

Merged
merged 6 commits into from
Oct 25, 2024
Merged

Commits on Sep 12, 2024

  1. Fix incompatibility with ZFA's "head".

    In ZFA, the "head" (ZFA:0001114) corresponds to what Uberon calls the
    "craniocervical region" (UBERON:0007811), comprising the head proper and
    the neck. So we remap ZFA:0001114 to UBERON:0007811, rather than
    UBERON:0000033).
    
    Also, the axiom stating that 'pharyngeal arch' (UBERON:0002539) is part
    of the 'embryonic head' (UBERON:0008816) is bogus, as some pharyngeal
    arches are located in the neck rather than the head. So we create a new
    term 'embryonic craniocervical region' to be the embryonic counterpart
    of 'craniocervical region' (as 'embryonic head' is the embryonic
    counterpart of 'head'), and rewrite the aforementioned axiom to state
    that 'pharyngeal arch' is part of the 'embryonic craniocervical region'.
    
    Combined together, these two changes fix about 80 unsatisfiable classes
    in the merge product of Uberon and ZFA.
    
    closes #379
    gouttegd committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    5331655 View commit details
    Browse the repository at this point in the history
  2. Add xref for definition of 'embryonic craniocervical region'.

    Not really useful for a definition that is merely the English
    translation of the logical definition, but it keeps the CI checks happy.
    gouttegd committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    1d7f882 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2024

  1. Configuration menu
    Copy the full SHA
    136ec9b View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2024

  1. Configuration menu
    Copy the full SHA
    bce9d19 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2024

  1. Configuration menu
    Copy the full SHA
    d2e9cb5 View commit details
    Browse the repository at this point in the history
  2. Add GCI for 'part of some embryonic craniocervical region'.

    Add the following GCI axiom
    
      ('part of' some embryo) and ('part of' some 'craniocervical region')
        SubClassOf: 'part of' some 'embryonic craniocervical region'
    gouttegd committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    95cc4af View commit details
    Browse the repository at this point in the history