Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add regulates to relations which propagate 'in taxon'. #816

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

balhoff
Copy link
Member

@balhoff balhoff commented Oct 18, 2024

The historical usage of 'regulates' assumes it is within a single organism. For this reason we have the term regulates in another organism without that assumption. This PR adds 'regulates' to the relations which propagate 'in taxon'.

This is good for GO, but does seem to assume a biological context. I'm not sure if the definition of 'regulates' should be tweaked to make that context more clear.

See also geneontology/go-ontology#29010

@cmungall
Copy link
Contributor

We need to make sure this won't break existing ontologies or their downstream ontologies.

All regulates axioms are likely in GO - if GO passes with this then we should be good to GO. If GO axioms need changed then we need time for releases to percolate, otherwise mixing certain versions of RO and GO will introduce incoherencies.

@pgaudet
Copy link
Collaborator

pgaudet commented Oct 21, 2024

@cmungall

Can we give some review period for concerned groups to evalute the impact on their ontologies?

Otherwise we should look for an alternative strategy to propagate these TCs in GO.

@balhoff
Copy link
Member Author

balhoff commented Oct 28, 2024

I can try adding this to a test Ubergraph build to see if there are negative consequences.

@ddooley
Copy link
Contributor

ddooley commented Nov 4, 2024

Nov 4, 2024. Jim will do the test soon.

@balhoff
Copy link
Member Author

balhoff commented Nov 6, 2024

I checked this group of merged ontologies with this property chain, and didn't find any unsatisfiabilities: https://github.com/INCATools/ubergraph/blob/master/ci/test-merged.ofn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants