-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Throughput processor should be singleton #1842
Merged
BinaryFissionGames
merged 10 commits into
main
from
fix/custom-message-throughput-incorrect
Sep 6, 2024
Merged
fix: Throughput processor should be singleton #1842
BinaryFissionGames
merged 10 commits into
main
from
fix/custom-message-throughput-incorrect
Sep 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BinaryFissionGames
force-pushed
the
fix/custom-message-throughput-incorrect
branch
from
September 5, 2024 17:36
097cc93
to
f3c77ba
Compare
BinaryFissionGames
requested review from
dpaasman00 and
a team
as code owners
September 5, 2024 17:38
BinaryFissionGames
requested review from
jsirianni and
antonblock
and removed request for
jsirianni
September 5, 2024 17:38
antonblock
reviewed
Sep 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working well with the custom message change enabled in BP, just had a couple small comments
antonblock
approved these changes
Sep 6, 2024
Co-authored-by: Nico Stewart <antonblock@users.noreply.github.com>
BinaryFissionGames
force-pushed
the
fix/custom-message-throughput-incorrect
branch
from
September 6, 2024 18:21
bb25f58
to
dd8595b
Compare
BinaryFissionGames
deleted the
fix/custom-message-throughput-incorrect
branch
September 6, 2024 18:56
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Change
We were seeing some issues with measurements in BPOP. This was because when the same processor was included in multiple pipelines, it would create multiple instances. In that case, one processor would "win" the registration, and only measurements for that particular pipeline would be emitted.
This change makes it so that there is only one instance of the processor (this pattern is copied from the snapshot processor), so all the pipelines are accounted for. You can see that here in BPOP, where we have multiple sources (which end up being multiple pipelines) adding up correctly.
Checklist