Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't collect system.cpu.utilization per-cpu #4716

Merged
merged 1 commit into from
Apr 23, 2024
Merged

fix: don't collect system.cpu.utilization per-cpu #4716

merged 1 commit into from
Apr 23, 2024

Conversation

antonblock
Copy link

  • In hostmetricsreceiver, set percpu=false when calling cpu.TimesWithContext.
    • For Windows, this uses GetSystemTimes to get System-wide counters for CPU idle/system/user time.
    • This will create a single system.cpu.utilization metric with cpu attribute "cpu-total", which I think is suitable for our use case here

@antonblock antonblock merged commit f6f0fff into otel-0.92.0-windows7 Apr 23, 2024
8 of 68 checks passed
@antonblock antonblock deleted the fix/hostmetricsreceiver-cpuutilization-windows7 branch April 23, 2024 16:16
@antonblock antonblock mentioned this pull request Apr 23, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BinaryFissionGames BinaryFissionGames BinaryFissionGames approved these changes

@cpheps cpheps cpheps approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@antonblock @BinaryFissionGames @cpheps @djaglowski