Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bindplane_configuration) Platform does not need to force a new resource #118

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

jsirianni
Copy link
Member

@jsirianni jsirianni commented Aug 13, 2024

Description of Changes

The provider tries to delete and re-create a config when changing the platform. Currently there are no constraints here, we can just apply over the existing config to change its platform.

Testing

Make sure you have Goreleaser v2 installed.

Log into https://app.bindplane.com and create an API key.

  1. Run make test-local to build the provider for local testing.
  2. cd test/local
  3. Update main.tf to use app.bindplane.com and an API key instead of basic auth.
provider "bindplane" {
  remote_url = "https://app.bindplane.com
  api_key = "YOUR API KEY"
}

Run terraform apply.

Edit main.tf and change the bindplane_configuration resource's platform from linux to windows. Re-run apply and observe that it changes the configuration instead of trying to delete and re-create.

Please check that the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • CI passes

@jsirianni jsirianni changed the base branch from main to goreleaser-v2 August 20, 2024 15:26
@jsirianni jsirianni marked this pull request as ready for review August 20, 2024 19:06
@jsirianni jsirianni requested a review from a team as a code owner August 20, 2024 19:06
@jsirianni jsirianni requested a review from algchoo August 20, 2024 19:06
Base automatically changed from goreleaser-v2 to main August 28, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant