Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bindplane_configuration) Platform does not need to force a new resource #118

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -418,8 +418,8 @@ jobs:
- name: Test GoReleaser
uses: goreleaser/goreleaser-action@v5
with:
version: latest
args: release --snapshot --skip-publish --rm-dist --parallelism 2 --config release/goreleaser.yml
version: v2.1.0
args: release --snapshot --skip=publish --clean --parallelism 2 --config release/goreleaser.yml
env:
GPG_FINGERPRINT: ${{ steps.import_gpg.outputs.fingerprint }}

Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@ jobs:
- name: Run GoReleaser
uses: goreleaser/goreleaser-action@v5
with:
version: latest
args: release --rm-dist --config release/goreleaser.yml
version: v2.1.0
args: release --config release/goreleaser.yml
env:
GPG_FINGERPRINT: ${{ steps.import_gpg.outputs.fingerprint }}
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
22 changes: 11 additions & 11 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,12 @@ TOOLS_MOD_DIR := ./internal/tools

.PHONY: install-tools
install-tools:
cd $(TOOLS_MOD_DIR) && go install github.com/securego/gosec/v2/cmd/gosec@v2.16.0
cd $(TOOLS_MOD_DIR) && go install github.com/google/addlicense@v1.1.0
cd $(TOOLS_MOD_DIR) && go install github.com/mgechev/revive@v1.3.1
cd $(TOOLS_MOD_DIR) && go install github.com/uw-labs/lichen@v0.1.7
cd $(TOOLS_MOD_DIR) && go install github.com/goreleaser/goreleaser@v1.21.2
cd $(TOOLS_MOD_DIR) && go install github.com/client9/misspell/cmd/misspell@v0.3.4
cd $(TOOLS_MOD_DIR) && go install github.com/securego/gosec/v2/cmd/gosec
cd $(TOOLS_MOD_DIR) && go install github.com/google/addlicense
cd $(TOOLS_MOD_DIR) && go install github.com/mgechev/revive
cd $(TOOLS_MOD_DIR) && go install github.com/uw-labs/lichen
cd $(TOOLS_MOD_DIR) && go install github.com/goreleaser/goreleaser/v2
cd $(TOOLS_MOD_DIR) && go install github.com/client9/misspell/cmd/misspell

.PHONY: tidy
tidy:
Expand All @@ -47,19 +47,19 @@ tidy:
provider:
rm -rf dist/
goreleaser build \
--skip-validate \
--skip=validate \
--single-target \
--snapshot \
--config release/goreleaser.yml

.PHONY: release-test
release-test:
goreleaser release \
--skip-publish \
--skip-validate \
--skip=publish \
--skip=validate \
--snapshot \
--rm-dist \
--skip-sign \
--clean \
--skip=sign \
--config release/goreleaser.yml

.PHONY: ci-check
Expand Down
194 changes: 121 additions & 73 deletions internal/tools/go.mod

Large diffs are not rendered by default.

512 changes: 331 additions & 181 deletions internal/tools/go.sum

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion internal/tools/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ package main
import (
_ "github.com/client9/misspell/cmd/misspell"
_ "github.com/google/addlicense"
_ "github.com/goreleaser/goreleaser"
_ "github.com/goreleaser/goreleaser/v2"
_ "github.com/mgechev/revive"
_ "github.com/securego/gosec/v2/cmd/gosec"
_ "github.com/uw-labs/lichen"
Expand Down
2 changes: 1 addition & 1 deletion provider/resource_configuration.go
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ func resourceConfiguration() *schema.Resource {
"platform": {
Type: schema.TypeString,
Required: true,
ForceNew: true,
ForceNew: false,
ValidateFunc: func(val any, _ string) (warns []string, errs []error) {
platform := val.(string)
if !isValidPlatform(platform) {
Expand Down
3 changes: 2 additions & 1 deletion release/goreleaser.yml
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
version: 2

builds:
- id: provider
env:
Expand Down Expand Up @@ -39,7 +41,6 @@ release:
draft: false

changelog:
skip: false
use: github
sort: asc
groups:
Expand Down
Loading