Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #384.
This is likely to be a large amount of work: d3-format doesn’t support specifying a locale string, and instead you’re responsible for loading your own locale definition using d3.formatLocale. It would therefore be better to using number.toLocaleString (Intl.NumberFormat) and rely on the browser’s implementation. But this would mean no longer using d3-scale’s tick format implementation.
So either we continue to use d3-format and are responsible for providing locale definitions for every conceivable locale (and almost certainly lacking parity with number.toLocaleString). Or we drop d3-format and its shorthand format specifier syntax and integration with d3-scale. 🤔
I guess the “easy” option would be to expose D3’s locale definition to the user (like Vega does), and then the user is responsible for it. Maybe that’s the best we can do in the short term but it certainly would be more satisfying if we could leverage the deep support for localization in modern browsers.