Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin: BuJo Bullets #4314

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Conversation

frankolson
Copy link
Contributor

@frankolson frankolson commented Oct 3, 2024

I am submitting a new Community Plugin

Repo URL

Link to my plugin: https://github.com/frankolson/obsidian-bujo-bullets

Release Checklist

  • I have tested the plugin on
    • Windows
    • macOS
    • Linux
    • Android (if applicable)
    • iOS (if applicable)
  • My GitHub release contains all required files (as individual files, not just in the source.zip / source.tar.gz)
    • main.js
    • manifest.json
    • styles.css (optional)
  • GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
  • The id in my manifest.json matches the id in the community-plugins.json file.
  • My README.md describes the plugin's purpose and provides clear usage instructions.
  • I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my plugins's adherence to these policies.
  • I have read the tips in https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines and have self-reviewed my plugin to avoid these common pitfalls.
  • I have added a license in the LICENSE file.
  • My project respects and is compatible with the original license of any code from other plugins that I'm using.
    I have given proper attribution to these other projects in my README.md.

Copy link

github-actions bot commented Oct 3, 2024

Hello!

I found the following issues in your plugin submission

Errors:

❌ Could not parse community-plugins.json, invalid JSON. Unexpected token ']', ..."ets"
},
]
" is not valid JSON


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

Copy link

github-actions bot commented Oct 3, 2024

Hello!

I found the following issues in your plugin submission

Errors:

❌ Please don't include Obsidian in the plugin description
❌ Unable to find a release with the tag 1.0.1. Make sure that the version in your manifest.json file in your repo points to the correct Github Release.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

Copy link

github-actions bot commented Oct 3, 2024

Hello!

I found the following issues in your plugin submission

Errors:

❌ Unable to find a release with the tag 1.0.1. Make sure that the version in your manifest.json file in your repo points to the correct Github Release.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@github-actions github-actions bot changed the title Add Bujo Bullets plugin Add plugin: BuJo Bullets Oct 3, 2024
@ObsidianReviewBot
Copy link
Collaborator

The automated review has not found any issues with your code, assigning human for additional review.

@frankolson
Copy link
Contributor Author

frankolson commented Oct 15, 2024

Hey @joethei, any way I could get an eye on this? 🙏

Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ The newly added entry is not at the end, or you are submitting on someone else's behalf. The last plugin in the list is: mProjectsCode/obsidian-lemons-search-plugin. If you are submitting from a GitHub org, you need to be a public member of the org.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@frankolson
Copy link
Contributor Author

Hey @joethei, I'm not sure how to resolve the "This branch cannot be rebased due to conflicts" error. Any suggestions?

@joethei
Copy link
Collaborator

joethei commented Oct 23, 2024

Ignore that, I will handle that when it's time to merge.

@joethei
Copy link
Collaborator

joethei commented Oct 23, 2024

"description": "Alternate checkbox types for Obsidian to support Bullet Journal bullets",
Avoid including sentences like "This is a plugin for Obsidian that does ..." in your description, it should be self-evident that this is a plugin for Obsidian.
We have published a guide for plugin descriptions to follow here: https://docs.obsidian.md/Plugins/Releasing/Submission+requirements+for+plugins#Keep+plugin+descriptions+short+and+simple.

Where is the actual source code?
That needs to be uploaded to the repo, atm there is no code, even the main.js in the release is empty.

@joethei joethei added Changes requested Minor changes requested PR can be merged after some final changes have been requested and removed Ready for review labels Oct 28, 2024
Copy link

Hi there, as this PR has not seen any activity in the last 30 days, it will be closed in 15 days unless there are any updates.

@github-actions github-actions bot added the stale label Nov 28, 2024
Copy link

Hi there, as this PR has not seen any activity in the last 30 days, it will be closed in 15 days unless there are any updates.

@github-actions github-actions bot added the stale label Dec 30, 2024
@frankolson
Copy link
Contributor Author

@joethei, sorry about that. I had the changes in a local branch 🤦‍♂️. Those are published now and I have made updates to the plugin description as requested

@ObsidianReviewBot ObsidianReviewBot added Ready for review Changes made and removed Changes requested Minor changes requested PR can be merged after some final changes have been requested labels Jan 3, 2025
@ObsidianReviewBot ObsidianReviewBot removed their assignment Jan 3, 2025
@ObsidianReviewBot
Copy link
Collaborator

The automated review has not found any issues with your code, ready for manual review.

@joethei
Copy link
Collaborator

joethei commented Jan 6, 2025

# Obsidian BuJo Bullets
Naming something "Obsidian xyz" is reserved for first party products we create, please change this header.

const fileContent = await vault.read(file)
It would be better to use the newish process function, that will make sure that no other plugin will mess up your edits.
For that you will need to raise the minAppVersion.

bulletss
Typo.

@joethei joethei added Changes requested Minor changes requested PR can be merged after some final changes have been requested and removed Ready for review Changes made labels Jan 6, 2025
Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ Unable to find a release with the tag 1.0.2. Make sure that the version in your manifest.json file in your repo points to the correct Github Release.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

Re-add accidentally removed newline
@frankolson
Copy link
Contributor Author

@joethei, I've implemented the requested changes. However, I couldn't figure out how to tell what the minimum version needed is for using the process function, so I just assumed it was part of the last major version update. Let me know if that should be updated

@ObsidianReviewBot ObsidianReviewBot added Ready for review Changes made and removed Changes requested Minor changes requested PR can be merged after some final changes have been requested labels Jan 14, 2025
@ObsidianReviewBot ObsidianReviewBot removed their assignment Jan 14, 2025
@ObsidianReviewBot
Copy link
Collaborator

The automated review has not found any issues with your code, ready for manual review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants