Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Workspace 145 #138

Merged
merged 14 commits into from
Sep 27, 2024
Merged

feat: Workspace 145 #138

merged 14 commits into from
Sep 27, 2024

Conversation

SKairinos
Copy link
Contributor

@SKairinos SKairinos commented Sep 27, 2024

This change is Reviewable

@SKairinos SKairinos linked an issue Sep 27, 2024 that may be closed by this pull request
Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @SKairinos)


codeforlife/user/migrations/0001_initial.py line 16 at r1 (raw file):

        ("common", "0054_delete_aimmo_models"),
        ("auth", "0012_alter_user_first_name_max_length"),
        ("common", "0054_delete_aimmo_models"),

Shouldn't need that common migration twice

Copy link
Contributor Author

@SKairinos SKairinos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 2 of 5 files reviewed, 1 unresolved discussion (waiting on @faucomte97)


codeforlife/user/migrations/0001_initial.py line 16 at r1 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

Shouldn't need that common migration twice

oops. merge gone wrong. regenerated the migration

Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SKairinos)

@SKairinos SKairinos merged commit c749c7c into main Sep 27, 2024
5 of 6 checks passed
@SKairinos SKairinos deleted the workspace-145 branch September 27, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adapt migrations to Postgres
2 participants