Support camlp5 by using Toploop.parse_toplevel_phrase instead of Parse.toplevel_phrase #486
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves issue #485 (and the equivalent issue discussed in this thread) by fixing the definition of
parse_toplevel_phrase_default
ofUTop
to use!Toploop.parse_toplevel_phrase
instead ofParse.toplevel_phrase
.Note that
!Toploop.parse_toplevel_phrase
is equal toParse.toplevel_phrase
when utop was just initiated: https://github.com/ocaml/ocaml/blob/trunk/toplevel/topcommon.ml#L29However, a user may add its preprocessor to
Toploop.parse_toplevel_phrase
later using camlp5, making!Toploop.parse_toplevel_phrase
andParse.toplevel_phrase
unequal.This patch simply replaces
Parse.toplevel_phrase
with!Toploop.parse_toplevel_phrase
so that the preprocessor can do its work.