Skip to content

Commit

Permalink
Make it a warning if ocamlc is missing (#1642)
Browse files Browse the repository at this point in the history
If you're using the dune developer preview then ocamlc won't be globally
installed. It's a bit offputting to have the plugin pop up with an error
every time vscode starts, especially since the plugin seems to work fine
without it. This downgrades it to a warning.

Signed-off-by: Stephen Sherratt <stephen@sherra.tt>
  • Loading branch information
gridbugs authored Nov 12, 2024
1 parent 1113a5d commit 52fac75
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
- Add `ocaml.copy-type-under-cursor` to copy, in the clipboard the type of
the expression under the cursor (#1582)

- Make it a warning if ocamlc is missing (#1642)

## 1.20.1

- This was a version bump only, there were no changes
Expand Down
2 changes: 1 addition & 1 deletion src/extension_instance.ml
Original file line number Diff line number Diff line change
Expand Up @@ -372,7 +372,7 @@ let update_ocaml_info t =
| `Ocamlc_missing ->
let (_ : unit Promise.t) =
let+ maybe_choice =
Window.showErrorMessage
Window.showWarningMessage
~message:
"OCaml bytecode compiler `ocamlc` was not found in the current \
sandbox. Do you have OCaml installed in the current sandbox?"
Expand Down

0 comments on commit 52fac75

Please sign in to comment.