Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the gallery banner to OCaml color #1293

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Change the gallery banner to OCaml color #1293

merged 1 commit into from
Nov 30, 2023

Conversation

smorimoto
Copy link
Collaborator

@smorimoto smorimoto commented Nov 30, 2023 •
edited
Loading

@smorimoto
Change the gallery banner to OCaml color
edbe902 
Signed-off-by: Sora Morimoto <sora@morimoto.io>
@smorimoto
Copy link
Collaborator Author

I've tried to use dark theme or darker colors, but most other combinations fail the accessibility test.

Screenshot 2023-11-30 at 19 02 32

@smorimoto
Copy link
Collaborator Author

For the colour, I picked from here: https://github.com/ocaml/ocaml-logo/blob/18923642786f54c91f9ff07140ab5738d81771d0/Colour/SVG/colour-logo.svg#L41

@smorimoto smorimoto merged commit fc7de5e into master Nov 30, 2023
8 of 9 checks passed
@smorimoto smorimoto deleted the gallery-banner branch November 30, 2023 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnxn mnxn mnxn approved these changes

Assignees
No one assigned
Labels
no changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smorimoto @mnxn