Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): bump js_of_ocaml to >=5.52 #1325

Closed
wants to merge 1 commit into from
Closed

chore(deps): bump js_of_ocaml to >=5.52 #1325

wants to merge 1 commit into from

Conversation

tatchi
Copy link
Collaborator

@tatchi tatchi commented Jan 5, 2024

It seems to reduce the package size.

Master

dist/vscode_ocaml_platform.bc.js      5.0mb

du -sh test_extension.vsix
1.7M    test_extension.vsix

This PR

dist/vscode_ocaml_platform.bc.js      3.2mb

du -sh test_extension.vsix
1.0M    test_extension.vsix

@tatchi tatchi added the dependencies Pull requests that update a dependency file label Jan 5, 2024
@smorimoto
Copy link
Collaborator

I don't think this is going to change anything. Even without this change, opam should use the latest jsoo by default.

@tatchi
Copy link
Collaborator Author

tatchi commented Jan 5, 2024

Ah right there's no upper bound. Feel free to close if you want 🤗

@smorimoto smorimoto closed this Jan 5, 2024
@smorimoto smorimoto deleted the bump-js-of-ocaml branch January 5, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smorimoto smorimoto smorimoto approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file no changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tatchi @smorimoto