-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Construct custom request implementation #1646
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
voodoos
reviewed
Nov 15, 2024
voodoos
reviewed
Nov 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Pizie, it's already in a very good state :-)
Co-authored-by: Ulysse <5031221+voodoos@users.noreply.github.com>
…rm into construct_
voodoos
approved these changes
Nov 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes, this looks good to go!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Construct
Introduction
This PR implements the Construct Custom Requests.
UX
Trigger this request using
Alt+C
on a typedhole to select possible construct values. If you select a value with more typedholes, it will continuously display more construct values.You may also trigger this request from the general commands menu.
Notifications
Ocamllsp warning
: Ifocamllsp
is not running at the time the command is invoked, this notification is displayed.No support for requests
: If the version of ocamllsp doesn't publish theocamllsp/handleConstruct
capability then this notification is displayed.Commands
One command is published
ocaml.construct
which triggers the process.Key bindings
The key binding
Alt+C
triggers this command.Demo
ocaml.construct.mp4
References
cc @voodoos