Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make construct chaining configurable #1673

Merged
merged 12 commits into from
Dec 6, 2024

Conversation

PizieDust
Copy link
Contributor

This PR provides a configurable option for construct chaining.
The default behavior let's construct automatically compute values for the next typed hole. This option can be used to turn this behavior off.

"ocaml.server.construct.chainConstruct": true

image

cc @voodoos

@smorimoto smorimoto added the type: feature New feature or request label Dec 5, 2024
@PizieDust PizieDust changed the title Make construct configurable Make construct chaining configurable Dec 5, 2024
Copy link
Collaborator

@voodoos voodoos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, apart from some nitpicking on the name choices this looks good to me.

CHANGELOG.md Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
vscode.opam Outdated Show resolved Hide resolved
smorimoto and others added 3 commits December 6, 2024 03:28
Co-authored-by: Ulysse <5031221+voodoos@users.noreply.github.com>
Copy link
Collaborator

@voodoos voodoos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me

@smorimoto smorimoto merged commit 6a7b951 into ocamllabs:master Dec 6, 2024
6 checks passed
@PizieDust PizieDust deleted the construct_config branch December 6, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants