-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve WW3 mesh cap to allow using vortex formulation in ocean side #11
Comments
The |
from @DeniseWorthen email:In wav_import_export there are several "calc" routines which we moved over from the old esmf cap to the new mesh cap. I think some of the fields I see listed (like the stokes-drift spectrum, calcstokes3d) are there in the old cap, but were not added to the new cap. I think it is straightforward to add them to the new cap. Some of the other fields---well, I have no idea what internal WW3 fields correspond to the needed export. But, if it is calculated as a "history" field in WW3, I think you could make them available by adding additional "calc" routines in wav_import_export. For example, in wav_grdout, I see varatts( "BHD ", "BHD ", "Bernoulli head (J term) ", "m2 s-2 ", " ", .false.) and if I look in w3iogomd, I see how that term is calculated on LN 1653. I think you can find the bottom momentum fluxes also. As for units, I'm not 100% sure I got them right when I wrote the wav_grdout. Ana has found a couple of errors (I still have on my list to fix these!). I think you'll need to rely on wave modelers to be entirely sure of the units. |
@uturuncoglu @DeniseWorthen transferring conversation on this issue from email to GH! thx |
For point of clarify, you do want any export fields to be calculated in the cap, and not just use them from the internal fields that WW3 might calculate as an output variable. The reason is that the output variables are only calculated at some set frequency, and you want the export fields to be updated at each modelAdvance. See NOAA-EMC#843 |
@DeniseWorthen Yes, it would be nice to have them in the cap and updated with coupling frequency. It would be also nice to have them in the output but we could still output import and export states for debugging purpose. |
from @DeniseWorthen: w3ounfmetamd.F90 is script with BHD, etc. units as above... |
Denise Worthen - NOAA Affiliate |
Denise Worthen - NOAA Affiliate |
See in this file (in ufs-weather there is one) in application level: something like this: |
|
Just to document chats from the meeting:Jana Haddad - NOAA Affiliate |
Thank you all! Here is the list of arrays we need from WW3:
|
Take the bottom momentum fields as an example: It appears to be calculated in
This is the code (and any preceding code on which it depends) which would need to be added in
a) define pointers to the esmf fields:
b) check that the field is required in the export state using and get pointers to the fields
c) Create a "calc" routine to calculate the fields, replicating whatever is required from the
At this point, the bottom stress should be ready to be exported by WW3 at every model advance. There is more to be done however to get them sent to another component:
|
Summary from meeting 5/28:
Next steps:need to eventually merge import_export work that's already done for the 2d coupling:
in the meantime:
attendees: @DeniseWorthen @saeed-moghimi-noaa @josephzhang8 @pvelissariou1 @aliabdolali @AliS-Noaa Saeideh Banihashemi @yunfangsun |
Here is the history showing Ufuk's addition of radiation stress components to wav_import_export.f90, on the UFS Coastal side: He added to advertise_fields SR:
and corrected those names in export_fields SR. Looks like those changes have not been merged to UFS-WM's WW3 branch. See here. |
I need to amend what I wrote previously, because it appears that
|
Thx @DeniseWorthen for your instructions! |
@josephzhang8 Thanks, I should have looked more carefully. I think it should actually just be
since taubbl allocated as (nsealm,2) |
That makes sense. Thx @DeniseWorthen |
The list of WW3 variables SCHISM needs (from OASIS ): |
@aliabdolali many thanks for taking time help us set up the test! You can find the setup for SCHISM-WWM for the analytical case at: The web may warn you about potential risk; just accept and you'll see the dir (our IT guy is still looking to upgrade). Let me know if you have any questions. Thx! |
@DeniseWorthen @josephzhang8 I think we could use this issue for WW3 implementation. I'll open another one under SCHSIM-ESMF to track issues specifically for ocean component. |
I can access till /work2/noaa/stmp/tufuk/stmp/tufuk |
@danishyo Okay. I think I fixed it. Could you try again? |
No, I can reach to /work2/noaa/stmp/tufuk/stmp/tufuk/FV3_RT/ |
Strange. Could you try again? |
It works now, thanks!
Ufuk Turunçoğlu ***@***.***>於 2024年9月10日 週二,下午6:07寫道:
… Strange. Could you try again?
—
Reply to this email directly, view it on GitHub
<#11 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AM3S4J4V7H64K52UWBXKRMLZV5USBAVCNFSM6AAAAABHU5JEW6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNBSGEYDCOJSGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Hi @uturuncoglu I got the following compile error on Hercules but this does not happen on Frontera. Hercules compiling error are as following: |
@danishyo The fd_ufs.yaml was updated version in my run directory but it was linked to the source. So, maybe you could not copy that one due to the permission issue. As I understand, you fix that one. Right? Hercules compile error seems something strange. It seems that you are having issue to find the ESMF library. So maybe you are compiling model in a wrong way. Let me checkout the branch and try again in my end. It was working for me on Hercules. |
Hi @uturuncoglu, yes, I fixed that one for frontera run (copy from ufs-weather-model/tests/parm/fd_ufs.yaml). I use exactly the same command after "git clone" to compile on hercules, but the error came out. Since it is compile under spack-stack env, my module env should not affect it, right? My modules loaded on hercules are the following: Currently Loaded Modules:
|
@danishyo I am not sure. It could interfere. Please try to run |
Thanks @uturuncoglu, I clone another copy and it can compile without problem on hercules now. |
@danishyo This probably indicates an issue w/ your mod_def file being inconsistent. Is your run on hercules? |
Hi @DeniseWorthen, yes, you can find it at /work2/noaa/nosofs/Dan/UFS/YunFang_case/Test_DUCK/ufs_schism_ww3 |
Is "Duck" the same domain as "Ike"? |
If you are refering ike_shinnecock, they are not the same domain. |
From the excde (17) message you're seeing, I think it might be failing in reading the mod_def file. A new mod_def file was created for Duck, right? Lines 655 to 665 in 80a5ad5
|
Yes, mod_def.ww3 & nest.ww3 are generated by standard-alone ww3_grid & ww3_bounc, and ww3_shel can run with them without problem. |
I think I found the problem, thanks @DeniseWorthen ‘s hint. In coastal_app, switch are In this schism_3d branch, switch are Now the case can run successfully, but I got similar result as coastal_app. Both standard-alone WW3 & schism_3d shows similar result as the following figure. SCHISM-WWM with VOR coupling result looks like the following: |
@danishyo Good progress! |
Hi @sbanihash, Thank you very much for your suggestions today. We and @danishyo will check our configurations again. And could you please share your WW3 stand-alone setting on Hercules @danishyo ? |
Hi, my standard-alone WW3 duck test configuration on Hercules is at /home/feiye/work2_Dan/UFS/YunFang_case/Test_DUCK/test_ww3/ |
Based on @aliabdolali ’s suggestion, check “direction” from spec nc file. Also, in original nc file, direction is about 0~10 degree, which means origin from East., In netcdf convention also show like the following: Assuming WW3 use origin from North, after rotating 90 degrees in spec nc, (direction+90, clockwise to 90 degrees), which means also origin from East, the standard-alone WW3 result is as follows, we finally got similar pattern. However, schism_3d couple SCHISM-WW3 looks like the following: I will keep checking other outputs to see the possible reason from this couple result. |
Thanks for the update! |
@danishyo yes, that is the option that needs to be activated. |
Hi all, I did some comparisons for both results, please see the following. |
Dan, I think, making sure WW3 boundary condition is correct seems to be the 1st order of the plan. There is a course grid schism-ww3 set up that Yunfag has worked on. It might be also handy if you compare those as well. Thanks |
Thanks @saeed-moghimi-noaa , sure, I can have a look to see anything still missed in the setting. |
Hi @danishyo Great job. To me wave pattern is very similar. Would you please check the spectra dimension. Seems like there is a missing g (=9.81) or a factor. or extra on the schism side. Would it be possible to also have crude comparison with observation. Or calculate record Hs from nodes very close to the boundary! Just a hunch, |
Background
[based on @uturuncoglu email] UFS Coastal is working on coupling WW3 and SCHISM. We're able to run 2D configurations of SCHISM + WW3 with mesh cap (or NCAR cap) without any issues, but we are preparing the way for running in 3D mode (https://github.com/oceanmodeling/ufs-coastal/issues/32). This requires additional fields from WW3.
The aim is to add missing fields to the WW3 cap (I think they are already available through OASIS complier) and complete the wiring with the SCHSIM (the interaction with wave with new formulation is already implemented) to enable 3d coupling
Info needed to proceed
https://github.com/NOAA-EMC/WW3/blob/d9b3172f4197c65d471662c6952a668152d71230/model/src/wav_import_export.F90#L138
WW3/model/src/wav_import_export.F90
Line 139 in 80a5ad5
@DeniseWorthen we will follow up for a description of what we're searching for here !
cc @josephzhang8 @uturuncoglu @yunfangsun @saeed-moghimi-noaa @anntsay
The text was updated successfully, but these errors were encountered: