Drop python 3.8 and add python 3.12 #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I.e. now we should be able to do this: ``` python import searvey coops = searvey.get_coops_stations() ioc = searvey.get_ioc_stations() usgs = searvey.get_usgs_stations() ```
Codecov Report
@@ Coverage Diff @@
## master #115 +/- ##
==========================================
+ Coverage 90.04% 90.06% +0.01%
==========================================
Files 13 13
Lines 1015 1017 +2
Branches 151 151
==========================================
+ Hits 914 916 +2
Misses 55 55
Partials 46 46
|
Fixes oceanmodeling#104 ``` .venv/lib/python3.10/site-packages/searvey/ioc.py:147: FutureWarning: Passing literal html to 'read_html' is deprecated and will be removed in a future version. To read from a literal string, wrap it in a 'StringIO' object. df = pd.read_html(html)[0] ```
SorooshMani-NOAA
approved these changes
Oct 31, 2023
There was a problem hiding this comment.
Thank you @pmav99, looks good. Do we need to specify numpy version lower bound too, or leaving it as * is OK?
|
I think it is OK like this. When the dependency resolver ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason we are kind of forced to drop python 3.8 is numpy who is following NEP 29: https://numpy.org/neps/nep-0029-deprecation_policy.html