Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add accesslists contracts #868

Merged
merged 22 commits into from
Aug 13, 2024
Merged

add accesslists contracts #868

merged 22 commits into from
Aug 13, 2024

Conversation

alexcos20
Copy link
Member

add access lists contracts

@alexcos20 alexcos20 self-assigned this Jun 28, 2024
/**
* @notice Batch Mint only for owner
*/
function batchMint(address[] memory user,string[] memory tokenURI) external onlyOwner

Check notice

Code scanning / Slither

Local variable shadowing Low

super._beforeTokenTransfer(from, to, tokenId, batchSize);
}

function _add(address user, string memory tokenURI) private returns (uint256) {

Check notice

Code scanning / Slither

Local variable shadowing Low

contract AccessList is Ownable, ERC721Enumerable,ERC721URIStorage {
using Counters for Counters.Counter;
Counters.Counter private _tokenIds;
constructor(string memory _name, string memory _symbol)

Check notice

Code scanning / Slither

Local variable shadowing Low

return newItemId;
}

function mint(address user, string memory tokenURI) external onlyOwner returns (uint256) {

Check notice

Code scanning / Slither

Local variable shadowing Low

contract AccessList is Ownable, ERC721Enumerable,ERC721URIStorage {
using Counters for Counters.Counter;
Counters.Counter private _tokenIds;
constructor(string memory _name, string memory _symbol)

Check notice

Code scanning / Slither

Local variable shadowing Low

@alexcos20 alexcos20 requested a review from mihaisc June 28, 2024 13:02
@alexcos20 alexcos20 marked this pull request as ready for review June 28, 2024 13:03
@alexcos20 alexcos20 requested a review from trentmc as a code owner June 28, 2024 13:03
Copy link

openzeppelin-code bot commented Jun 28, 2024

add accesslists contracts

Generated at commit: c49d299518525c34a28129d6b40ac8bb826cf11d

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
2
1
0
10
39
52
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

Copy link
Member

@trentmc trentmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have much to say on this. I'm assuming it's a copy and paste of standard open zeppelin contracts. If you want a more thorough review, perhaps sdk Berkay?

@alexcos20 alexcos20 changed the base branch from main to release/v2.1.0 August 13, 2024 08:24
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slither found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@alexcos20 alexcos20 merged commit 3e8cc6c into release/v2.1.0 Aug 13, 2024
9 checks passed
@alexcos20 alexcos20 deleted the feature/accesslists branch August 13, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants