Fix casts in C implementation for GCC 14 #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix casts performed in the C extension module to make it build with GCC 14. This involves adding two missing casts from `Blake3Object *` to `PyObject *` for return values, and fixing casts in method definitions to use `PyCFunction` (i.e. the type expected by the struct) rather than `PyCFunctionWithKeywords` (i.e. the type that's actually used by the function, and that wouldn't require a cast in the first place). Fixes oconnor663#43
|
Thanks! CI breaks are unrelated, fixed in 524b499. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix casts performed in the C extension module to make it build with GCC 14. This involves adding two missing casts from
Blake3Object *toPyObject *for return values, and fixing casts in method definitions to usePyCFunction(i.e. the type expected by the struct) rather thanPyCFunctionWithKeywords(i.e. the type that's actually used by the function, and that wouldn't require a cast in the first place).Fixes #43