Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix yaml tag parsing #486

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Fix yaml tag parsing #486

merged 1 commit into from
Sep 3, 2024

Conversation

wlynch
Copy link
Collaborator

@wlynch wlynch commented Sep 3, 2024

Switches yaml parsing library to sigs.k8s.io/yaml which respects json field tags. This fixes yaml parsing for policies, since previously it was not respecting the tags.

Also adds a test!

Switches yaml parsing library to sigs.k8s.io/yaml which respects json
field tags. This fixes yaml parsing for policies, since previously it
was not respecting the tags.

Also adds a test!
"k8s.io/apimachinery/pkg/util/sets"
"sigs.k8s.io/yaml"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's my favorite

@wlynch wlynch merged commit f8c6221 into octo-sts:main Sep 3, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants