Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: exception "mediatype is null or empty" when trying to delete file #2870

Closed
1 task done
b3b00 opened this issue Jan 30, 2024 · 3 comments · May be fixed by #2871
Closed
1 task done

[BUG]: exception "mediatype is null or empty" when trying to delete file #2870

b3b00 opened this issue Jan 30, 2024 · 3 comments · May be fixed by #2871
Labels
Status: Stale Used by stalebot to clean house Type: Bug Something isn't working as documented

Comments

@b3b00
Copy link

b3b00 commented Jan 30, 2024 •
edited
Loading

What happened?

When trying to delete a file using

var deleteRequest =   new DeleteFileRequest($"delete file", content.content.Sha);
await gitHubClient.Repository.Content.DeleteFile(RepositoryId,$"notes/{noteName}.md" , deleteRequest);

I get the following exception

System.ArgumentException: The value cannot be null or empty. (Parameter 'mediaType')
   at System.Net.Http.Headers.MediaTypeHeaderValue.CheckMediaTypeFormat(String mediaType, String parameterName)
   at System.Net.Http.StringContent..ctor(String content, Encoding encoding, String mediaType)
   at Octokit.Internal.HttpClientAdapter.BuildRequestMessage(IRequest request) in /_/Octokit/Http/HttpClientAdapter.cs:line 147
   at Octokit.Internal.HttpClientAdapter.Send(IRequest request, CancellationToken cancellationToken, Func`2 preprocessResponseBody) in /_/Octokit/Http/HttpClientAdapter.cs:line 48
   at Octokit.Connection.RunRequest(IRequest request, CancellationToken cancellationToken, Func`2 preprocessResponseBody) in /_/Octokit/Http/Connection.cs:line 761
   at Octokit.Connection.Run[T](IRequest request, CancellationToken cancellationToken, Func`2 preprocessResponseBody) in /_/Octokit/Http/Connection.cs:line 752
   at Octokit.Connection.Delete(Uri uri, Object data) in /_/Octokit/Http/Connection.cs:line 602

Versions

latest version : octokit.net v9.1.1 (did not try previous versions)

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@b3b00 b3b00 added Status: Triage This is being looked at and prioritized Type: Bug Something isn't working as documented labels Jan 30, 2024
@b3b00 b3b00 changed the title [BUG]: exception [BUG]: exception "mediatype is null or empty" when trying to delete file Jan 30, 2024
b3b00 added a commit to b3b00/octokit.net that referenced this issue Jan 30, 2024
@b3b00
bugfix octokit#2870
3848a79
@b3b00
Copy link
Author

b3b00 commented Jan 30, 2024

I've debugged and found a quick fix (see 3848a79). But I guess it's a bit too optimistic as the Connection.Deletemethod may be used to delete other resources that does not need content-type to be setted if no body is send with the HTTP DELETE request.

@b3b00 b3b00 mentioned this issue Jan 30, 2024
Open
2 tasks
@b3b00
Copy link
Author

b3b00 commented Jan 30, 2024

I've forgot to specify my dotnet env :

`
SDK .NET :
Version: 8.0.101
Commit: 6eceda187b
Workload version: 8.0.100-manifests.69afb982

Environnement d'exécution :
OS Name: Windows
OS Version: 10.0.19044
OS Platform: Windows
RID: win-x64
Base Path: C:\Program Files\dotnet\sdk\8.0.101\

Charges de travail .NET installées :
Workload version: 8.0.100-manifests.69afb982
Il n'y a aucune charge de travail installée à afficher.

Host:
Version: 8.0.1
Architecture: x64
Commit: bf5e279d92
`

@b3b00 b3b00 mentioned this issue Jan 30, 2024
Closed
@kfcampbell kfcampbell moved this from 🆕 Triage to 🔥 Backlog in 🧰 Octokit Active Feb 2, 2024
@kfcampbell kfcampbell removed the Status: Triage This is being looked at and prioritized label Feb 2, 2024
b3b00 pushed a commit to b3b00/octokit.net that referenced this issue Feb 4, 2024
@olduh29
bugfix octokit#2870
599ab35
b3b00 pushed a commit to b3b00/octokit.net that referenced this issue Feb 4, 2024
@olduh29
Merge branch 'main' into bugfix/octokit#2870-expecting-media-type-whe…
bdb5316 
…n-deleting-file

* main:
  [Feat] Allow build version to be passed in to build.ps1 via command line (octokit#2864)
  [Feat] Add Repository Autolinks Client (octokit#2868)
b3b00 added a commit to b3b00/octokit.net that referenced this issue Feb 4, 2024
@b3b00
Merge branch 'main' into bugfix/octokit#2870
768a1dd
nickfloyd added a commit to b3b00/octokit.net that referenced this issue Feb 21, 2024
@nickfloyd
Merge branch 'main' into bugfix/octokit#2870
e8bee6d
nickfloyd added a commit to b3b00/octokit.net that referenced this issue Jun 10, 2024
@nickfloyd
Merge branch 'main' into bugfix/octokit#2870-expecting-media-type-whe…
7cc1f8b 
…n-deleting-file
nickfloyd added a commit to b3b00/octokit.net that referenced this issue Jul 2, 2024
@nickfloyd
Merge branch 'main' into bugfix/octokit#2870
c12055a
@github-actions GitHub Actions
Copy link

👋 Hey Friends, this issue has been automatically marked as stale because it has no recent activity. It will be closed if no further activity occurs. Please add the Status: Pinned label if you feel that this issue needs to remain open/active. Thank you for your contributions and help in keeping things tidy!

@github-actions github-actions bot added the Status: Stale Used by stalebot to clean house label Oct 30, 2024
@github-actions github-actions bot closed this as completed Nov 7, 2024
@github-project-automation github-project-automation bot moved this from 🔥 Backlog to ✅ Done in 🧰 Octokit Active Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Stale Used by stalebot to clean house Type: Bug Something isn't working as documented
Projects
🧰 Octokit Active
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bugfix #2870 b3b00/octokit.net
2 participants
@b3b00 @kfcampbell