Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: v21 fails eslint-plugin-import's no-unresolved rule #446

Open
1 task done
travi opened this issue Jul 11, 2024 · 3 comments
Open
1 task done

[BUG]: v21 fails eslint-plugin-import's no-unresolved rule #446

travi opened this issue Jul 11, 2024 · 3 comments
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone Type: Bug Something isn't working as documented

Comments

@travi
Copy link

travi commented Jul 11, 2024

What happened?

the main property has been removed, resulting in eslint failures for the import/no-unresolved. unfortunately, even though an exports map should cover everything needed, this plugin is unable to understand the exports map. see import-js/eslint-plugin-import#1810 for full info.

would you mind including the main property and pointing it at the same file as the exports map for backward compatibility?

Versions

@octokit/rest v21.0.0

Relevant log output

1:26  error  Unable to resolve path to module '@octokit/rest'  import/no-unresolved

https://github.com/form8ion/github/actions/runs/9883429421/job/27298159380?pr=15#step:5:78

Code of Conduct

  • I agree to follow this project's Code of Conduct
@travi travi added Status: Triage This is being looked at and prioritized Type: Bug Something isn't working as documented labels Jul 11, 2024
Copy link
Contributor

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@kfcampbell kfcampbell moved this from 🆕 Triage to 🔥 Backlog in 🧰 Octokit Active Jul 15, 2024
@kfcampbell kfcampbell added Status: Up for grabs Issues that are ready to be worked on by anyone and removed Status: Triage This is being looked at and prioritized labels Jul 15, 2024
@travi
Copy link
Author

travi commented Aug 30, 2024

i've encountered this in a few other octokit packages as well. if updating this would be accepted, i'd be happy to help out. would it be helpful to open similar issues for the other packages i've seen this in? i'm happy to open PRs as well, but would like confirmation that the contribution is a desired change. if PRs for this are desired, is a PR enough or should I start with issues?

@littlebutt
Copy link

I've encountered this too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone Type: Bug Something isn't working as documented
Projects
Status: 🔥 Backlog
Development

No branches or pull requests

3 participants