Merge pull request #60 from oddbird/fixup-css

Fixup css
oddbird · Jan 16, 2023 · b45eb36 · b45eb36
2 parents c13cff7 + 195231f
commit b45eb36
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 19 deletions.
diff --git a/src/popover.css b/src/popover.css
@@ -1,34 +1,27 @@
-[popover='' i],
-[popover='auto' i],
-[popover='manual' i] {
-  display: none;
+[popover] {
   position: fixed;
-  top: 0;
-  left: 0;
-  padding: 1em;
+  z-index: 2147483647;
+  inset: 0;
+  padding: 0.25em;
   width: fit-content;
   height: fit-content;
-  border: 1px solid;
+  border: solid;
   background: canvas;
   color: canvastext;
   overflow: auto;
   margin: auto;
-  inset-inline-start: 0;
-  inset-inline-end: 0;
-  inset-block-start: 0;
-  inset-block-end: 0;
 }
 
 /* stylelint-disable selector-class-pattern */
-[popover='' i].\:open,
-[popover='auto' i].\:open,
-[popover='manual' i].\:open {
-  display: block;
-  position: fixed;
-  z-index: 2147483647;
+[popover]:not(.\:open) {
+  display: none;
 }
 /* stylelint-enable selector-class-pattern */
 
+[popover][anchor] {
+  inset: auto;
+}
+
 /* Necessary for compatibility with Chrome */
 [popover]:not(:-internal-popover-hidden) {
   display: block;

diff --git a/tests/basic.spec.ts b/tests/basic.spec.ts
@@ -44,7 +44,6 @@ test('popover as "manual"', async ({ page }) => {
 
 test('popover as "invalid"', async ({ page }) => {
   const popover = (await page.locator('#popover6')).nth(0);
-  await expect(popover).toBeVisible();
   await expect(
     async () => await popover.evaluate((node) => node.showPopover()),
   ).rejects.toThrow(