Skip to content

Commit

Permalink
SV-59 Fix precheck errors
Browse files Browse the repository at this point in the history
  • Loading branch information
odeialba committed May 3, 2024
1 parent 4d15a7d commit 99b26b4
Show file tree
Hide file tree
Showing 4 changed files with 21 additions and 4 deletions.
12 changes: 12 additions & 0 deletions .github/workflows/moodle-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,12 @@ jobs:
- php: '8.0'
moodle-branch: 'MOODLE_403_STABLE'
database: mariadb
- php: '8.0'
moodle-branch: 'MOODLE_404_STABLE'
database: pgsql
- php: '8.0'
moodle-branch: 'MOODLE_404_STABLE'
database: mariadb
- php: '8.1'
moodle-branch: 'MOODLE_401_STABLE'
database: pgsql
Expand All @@ -85,6 +91,12 @@ jobs:
- php: '8.1'
moodle-branch: 'MOODLE_403_STABLE'
database: mariadb
- php: '8.1'
moodle-branch: 'MOODLE_404_STABLE'
database: pgsql
- php: '8.1'
moodle-branch: 'MOODLE_404_STABLE'
database: mariadb

steps:
- name: Check out repository code
Expand Down
5 changes: 5 additions & 0 deletions .stylelintrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"rules": {
"selector-type-no-unknown": [ true, { ignoreTypes: ["/^ion-/"] } ]
}
}
4 changes: 2 additions & 2 deletions mobile/js/init.js
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ class AddonModSortVotingProvider {
return true;
}).catch((error) => {
// The WebService has thrown an error, this means that responses cannot be submitted.
return Promise.reject(error);
throw error;
});
}

Expand All @@ -69,7 +69,7 @@ class AddonModSortVotingProvider {
var error = response && response.warnings && response.warnings[0] ?
response.warnings[0] : new context.CoreError('');

return Promise.reject(error);
throw error;
}
});
});
Expand Down
4 changes: 2 additions & 2 deletions mobile/js/mobile_sortvoting.js
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ this.moveUp = (id) => {
var prevOption = document.querySelector("#item-" + prevId);

sortVotingList.insertBefore(option, prevOption);
}
};

this.moveDown = (id) => {
var options = document.getElementsByName('option[]');
Expand Down Expand Up @@ -114,4 +114,4 @@ this.moveDown = (id) => {
var nextOption = document.querySelector("#item-" + nextId);

sortVotingList.insertBefore(nextOption, option);
}
};

0 comments on commit 99b26b4

Please sign in to comment.