From 99b26b48c1b9ae2e7c3a6bfa967ca3e3c9477f16 Mon Sep 17 00:00:00 2001
From: Odei Alba <odeialba@gmail.com>
Date: Fri, 3 May 2024 17:04:31 +0200
Subject: [PATCH] SV-59 Fix precheck errors

---
 .github/workflows/moodle-ci.yml | 12 ++++++++++++
 .stylelintrc                    |  5 +++++
 mobile/js/init.js               |  4 ++--
 mobile/js/mobile_sortvoting.js  |  4 ++--
 4 files changed, 21 insertions(+), 4 deletions(-)
 create mode 100644 .stylelintrc

diff --git a/.github/workflows/moodle-ci.yml b/.github/workflows/moodle-ci.yml
index 2789d36..c591af4 100644
--- a/.github/workflows/moodle-ci.yml
+++ b/.github/workflows/moodle-ci.yml
@@ -67,6 +67,12 @@ jobs:
           - php: '8.0'
             moodle-branch: 'MOODLE_403_STABLE'
             database: mariadb
+          - php: '8.0'
+            moodle-branch: 'MOODLE_404_STABLE'
+            database: pgsql
+          - php: '8.0'
+            moodle-branch: 'MOODLE_404_STABLE'
+            database: mariadb
           - php: '8.1'
             moodle-branch: 'MOODLE_401_STABLE'
             database: pgsql
@@ -85,6 +91,12 @@ jobs:
           - php: '8.1'
             moodle-branch: 'MOODLE_403_STABLE'
             database: mariadb
+          - php: '8.1'
+            moodle-branch: 'MOODLE_404_STABLE'
+            database: pgsql
+          - php: '8.1'
+            moodle-branch: 'MOODLE_404_STABLE'
+            database: mariadb
 
     steps:
       - name: Check out repository code
diff --git a/.stylelintrc b/.stylelintrc
new file mode 100644
index 0000000..6410a5a
--- /dev/null
+++ b/.stylelintrc
@@ -0,0 +1,5 @@
+{
+  "rules": {
+    "selector-type-no-unknown": [ true, { ignoreTypes: ["/^ion-/"] } ]
+  }
+}
\ No newline at end of file
diff --git a/mobile/js/init.js b/mobile/js/init.js
index d1deeab..75fe6f0 100644
--- a/mobile/js/init.js
+++ b/mobile/js/init.js
@@ -43,7 +43,7 @@ class AddonModSortVotingProvider {
             return true;
         }).catch((error) => {
             // The WebService has thrown an error, this means that responses cannot be submitted.
-            return Promise.reject(error);
+            throw error;
         });
     }
 
@@ -69,7 +69,7 @@ class AddonModSortVotingProvider {
                     var error = response && response.warnings && response.warnings[0] ?
                             response.warnings[0] : new context.CoreError('');
 
-                    return Promise.reject(error);
+                    throw error;
                 }
             });
         });
diff --git a/mobile/js/mobile_sortvoting.js b/mobile/js/mobile_sortvoting.js
index 91ef00c..0ded6ff 100644
--- a/mobile/js/mobile_sortvoting.js
+++ b/mobile/js/mobile_sortvoting.js
@@ -85,7 +85,7 @@ this.moveUp = (id) => {
     var prevOption = document.querySelector("#item-" + prevId);
 
     sortVotingList.insertBefore(option, prevOption);
-}
+};
 
 this.moveDown = (id) => {
     var options = document.getElementsByName('option[]');
@@ -114,4 +114,4 @@ this.moveDown = (id) => {
     var nextOption = document.querySelector("#item-" + nextId);
 
     sortVotingList.insertBefore(nextOption, option);
-}
+};