Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zero-Copy Deserialization of Events #214

Open
wants to merge 35 commits into
base: main
Choose a base branch
from
Open

Zero-Copy Deserialization of Events #214

wants to merge 35 commits into from

Conversation

TTWNO
Copy link
Member

@TTWNO TTWNO commented Dec 1, 2024 •
edited
Loading

This will be a (likely long-running) PR with the eventual goal to get all user-facing event-types (UEFTs) to be created without allocating once we receive the zbus::Message type.

This current depends on a few facts that need further work:

  1. A way to deserialize borrowed bodies (current not working).
  2. A way to directly access information from a zbus::Message without using Clone:
    • Signature
    • ObjectPath (path)
    • UnqiueName (sender)
    • Body
    • and preferably without using locking.... I'm looking at you LazyLock<QuickFields> field in zbus::Message

This should improve performance, as initial evidence has shown.

Note that this also depends on the zbus-5.0 branch getting merged.

TTWNO added 30 commits November 23, 2024 09:07
@TTWNO
Update zbus dep too
2dccad1
@TTWNO
Fix conflict in mod.rs
ec18e06
@TTWNO
Add pub modifier for public Bus,Registry,Status proxies
2148522
@TTWNO
Update atspi-connections to zbus 5.x
21a1a28
@TTWNO
Use new static signature assertions
0813e78
@TTWNO
Fix tests so they run (many fail)
bde0829
@TTWNO
Formatting
7993334
@TTWNO
Body 'as_string' not necessary
f9fe399
@TTWNO
Fix additional tests via using string instead of static signature var…
ef83c32 
…iation; necessary due to dynamic/static difference
@TTWNO
formatting
b96a368
@TTWNO
use git instead of path
4eb576f
@TTWNO
Use pub modifier in traits
b538c53
@TTWNO
Test signature instead of string representation
b304dc0
@TTWNO
use static instead of const for structure defs
eaedf1e
@TTWNO
Remove unused impl
81d123c
@TTWNO
Rebase body sig checks from Event wrapper marshaling
a3118e4
@TTWNO
[WIP] use latest zbus on rebased main
7db7d8f
@TTWNO
Merge branch 'main' into zbus-5.0
e126e95
@TTWNO
Remove MissingSignature error (no longer possible); cleanup clippy
53d1a89
@TTWNO
Formatting
4c6c5c1
@TTWNO
Update versions due to MSRV incompatiblity of error type
947ea28
@TTWNO
doc link fix for new zbus
1ed6cc8
@TTWNO
Update MSRV
2ddb9e1
@TTWNO
Use owned zbus::Message for deserialization
e976961 
- avoids Atomic locks (happens on all calls of
  `Message::header()`)
- Update benches to reflect owned values
@TTWNO
Event now has a lifetime
2eaded5
@TTWNO
Make CacheEvents 'fake' borrowed
08dfb21
@TTWNO
Add some borrow information to structs
9cae819
@TTWNO
Some cleanups
2a97fb1
@TTWNO
Use git versions of modified packages
2679922
@TTWNO
What the fuck? Now I'm suspcious...
9baea0e
TTWNO and others added 5 commits November 25, 2024 00:12
@TTWNO
...so you have to actually collect...
b9ee978
@TTWNO
Reduce allocations
223fbd2 
- Change most `Message::body()` (which clones and allocates) into
  `Message::into_body()` which takes ownership of `self` and does not
  allocate.
- Still not possible for borrowed `MessageConversionBorrow::Body` types,
  so still WIP there.
@TTWNO
Show performance impact of calling Message::header()
54d5f14
@luukvanderduim
fix(warn): Ignore false positives of unused_imports
5247259
@luukvanderduim
fix(bench): Extract clones from inner loop
b18fe5b 
We were cloning in the inner loop of our benchmark.
This meant we were also measuring syscall latencies of malloc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TTWNO @luukvanderduim