Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose commands within the frameProcessor #352

Closed
GDYendell opened this issue Aug 1, 2024 · 1 comment · Fixed by #359
Closed

Expose commands within the frameProcessor #352

GDYendell opened this issue Aug 1, 2024 · 1 comment · Fixed by #359
Assignees

Comments

@GDYendell
Copy link
Collaborator

GDYendell commented Aug 1, 2024

To support e.g. start writing, stop writing in the hdf plugin. We would add a new IpcMsgVal for commands (MsgValCmdCommand), add command and request_commands methods to FrameProcessorController / FrameProcessorPlugin and then it should just be sent to the correct plugin based on the first part of the path (e.g. "hdf") and then only that plugin should have to handle the command subsystem.

request_commands should return a dictionary of command name to what parameters it takes, or None / empty dict if it does not take any parameters.
command should take a command name and a dict of parameters (again empty / not given if it does not take parameters)

@ajgdls
Copy link
Contributor

ajgdls commented Sep 13, 2024

See PR

#359

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants