Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix frequency of frames in LiveViewPlugin #331

Closed

Conversation

wnichols1
Copy link
Contributor

This fix is straightforward. I don't know why it is necessary to count the number of frames going out of the live-view when the frame-number is available. This is relevant when you are pushing several datasets per frame.

@GDYendell
Copy link
Collaborator

Discussed in the core meeting and we don't think it makes sense to go based on frame number because it doesn't work when there are multiple processes and each node will get blocks of 100 frames, or only odd frames, etc.. This is the reason it uses a simple counter, because it makes the logic local to the specific process rank without having to know how many other nodes there are.

The point about being able to publish the same frame number of multiple datasets is a good one. Currently it is possible to configure a list of datasets to publish, so it could map that list of datasets to a list of counters specific to each dataset, so that it is possible to send the Nth frame of every configured dataset. I will make an issue for this.

@GDYendell GDYendell closed this Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants