Modified the downsampling logic to be per dataset rather than global #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GDYendell
reviewed
Mar 7, 2024
GDYendell
approved these changes
Mar 18, 2024
There was a problem hiding this comment.
Looks good. Being picky I would suggest a rebase to "fixup" (squash without the commit message) the review changes into the first commit, but not a blocker.
Happy to merge this @timcnicholls ?
|
Thanks @GDYendell yes I'm happy to merge it. @ANeaves would you like me to do the rebase? |
|
Thanks @GDYendell, yes please @timcnicholls if you've time to do the rebase that'd be a great help |
timcnicholls
force-pushed
the
live-view-configured-dataset
branch
from
302b7e6
to
7c263bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #333
Created to complete the above tagged issue. The frame counter used to select which frames to pass on to the live view socket now counts per Dataset, so if multiple datasets have been selected to be forwarded, it will count them individually.