Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use latest odin-control #338

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Update to use latest odin-control #338

merged 1 commit into from
Mar 7, 2024

Conversation

GDYendell
Copy link
Collaborator

No description provided.

@GDYendell
Copy link
Collaborator Author

@timcnicholls do you think it would be sensible to remove the version and fetch the latest from GitHub? The reason I added the URL dependency was mainly so that the CI worked without odin-control being on PyPI. It is probably just as sensible to test the latest odin-control.

@timcnicholls
Copy link
Contributor

@timcnicholls do you think it would be sensible to remove the version and fetch the latest from GitHub? The reason I added the URL dependency was mainly so that the CI worked without odin-control being on PyPI. It is probably just as sensible to test the latest odin-control.

I think so. For a deployment we'd probably pin specific versions of both through explicit requirements anyway. If we introduce regressions into odin-control PRs that break something for odin-data we'd be better finding that out sooner through CI failing.

@GDYendell
Copy link
Collaborator Author

GDYendell commented Mar 7, 2024

OK I have just removed the specific version here instead of changing it.

@GDYendell GDYendell changed the title Update to odin-control 1.5.0 Update to use latest odin-control Mar 7, 2024
@GDYendell GDYendell merged commit 9309486 into master Mar 7, 2024
15 checks passed
@GDYendell GDYendell deleted the bump-odin-control branch March 7, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants