Update meta adapter to only send config with acquisition ID #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajgdls
approved these changes
Aug 6, 2024
GDYendell
force-pushed
the
meta-adapter-config
branch
from
bb8e55b
to
62657d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is an issue where the meta adapter status transitions in and out of the writing state on start, which can cause clients to trigger the detector too soon.
This changes the logic so that configuration changes are only sent down immediately if there is already a valid acquisition ID (rather than using
Noneand then setting the acquisition ID afterward) or otherwise to just update the config cache and send that down when the new acquisition ID is set. This makes things more robust and removes the need for clients to do things in a particular order.This is a workaround for allowing multiple acquisitions to be active at one time, so this is a problem that will go away in the future and then we won't have to do any config caching.
Related to DiamondLightSource/dodal#488.