Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the ability to specify attributes on HDF5Datasets #351

Merged
merged 3 commits into from
Aug 8, 2024
Merged

Add the ability to specify attributes on HDF5Datasets #351

merged 3 commits into from
Aug 8, 2024

Conversation

DominicOram
Copy link
Contributor

@DominicOram DominicOram commented Jul 23, 2024 •
edited
Loading

See DiamondLightSource/ADOdin#22

To test:

  • Run unit tests and confirm they pass

@DominicOram DominicOram mentioned this pull request Jul 23, 2024
Merged
1 task
GDYendell
GDYendell approved these changes Aug 1, 2024
View reviewed changes
Copy link
Collaborator

@GDYendell GDYendell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Only nitpicks.

python/src/odin_data/meta_writer/hdf5dataset.py Outdated Show resolved Hide resolved
python/src/odin_data/meta_writer/hdf5dataset.py Outdated Show resolved Hide resolved
python/src/odin_data/meta_writer/hdf5dataset.py Outdated Show resolved Hide resolved
python/tests/test_hdf5dataset.py Outdated Show resolved Hide resolved
@GDYendell GDYendell requested a review from ajgdls August 1, 2024 10:25
@DominicOram
Copy link
Contributor Author

Thanks for the review, comments addressed

@GDYendell GDYendell merged commit ab7af96 into odin-detector:master Aug 8, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajgdls ajgdls ajgdls approved these changes

@GDYendell GDYendell GDYendell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DominicOram @ajgdls @GDYendell