Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting hdf plugin frames to zero #355

Merged
merged 1 commit into from
Aug 15, 2024
Merged

Conversation

GDYendell
Copy link
Collaborator

@GDYendell GDYendell commented Aug 8, 2024

This ensures that the hdf frame count can be changed from 0 and then changed back to 0 again for free-run mode.

Fixes #306

Note: Added #354 during this work. This is why the call to set_name is required.

@GDYendell GDYendell requested a review from ajgdls August 8, 2024 16:47
Copy link
Contributor

@ajgdls ajgdls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good. I cannot believe we had this bug for so long without it being noticed before!

@GDYendell GDYendell merged commit acdcc9d into master Aug 15, 2024
15 checks passed
@GDYendell GDYendell deleted the hdf-zero-frames branch August 15, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

odin-data FileWriterPlugin does not accept 0 frames as a config setting.
2 participants