Implemented command and requestCommands methods in the FrameProcessor. #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timcnicholls
requested changes
Sep 16, 2024
There was a problem hiding this comment.
Thanks @ajgdls for doing this. I have a couple of comments/musings:
- the new
MsgValenum entries should also be added toIpcMessage::msg_val_map_init()inIpcMessage.cppto allow JSON encoding - in retrospect, now having a
MsgTypeofMsgTypeCmdand aMsgValofMsgValCmdCommandnow looks a bit odd. We can't changeMsgTypeCmdeasily without breaking existing code, but I wonder if the naming of the new value could be tweaked to separate them a bit? Maybe something likeMsgTypeCmdExecute? I'm not sure this is a huge issue, other than avoiding the need for a historical explanation 😉 - at some point we should add enumeration of the types and values to
IpcMessagein the python client...
👍 |
GDYendell
requested changes
Sep 17, 2024
GDYendell
reviewed
Sep 26, 2024
GDYendell
reviewed
Sep 26, 2024
GDYendell
reviewed
Sep 26, 2024
|
Hi @GDYendell @timcnicholls I have pushed the changes resulting from our conversation yesterday. |
GDYendell
reviewed
Sep 27, 2024
GDYendell
reviewed
Sep 27, 2024
|
OK I think this is ready for review again. I have also tested sending commands with a python test client to a running FrameProcessor application. |
timcnicholls
approved these changes
Oct 8, 2024
…e functionality. Fixed runtime error in Dummy plugin and throw an exception if the supported command is not requested when execution is called. Added tests that use the Dummy plugin to test execute and requestCommands methods. Update cpp/frameProcessor/test/DummyUDPProcessPluginTest.cpp Co-authored-by: Gary Yendell <gary.yendell@diamond.ac.uk> Added clarification comments. Simplified boost test calls. Updated to use string commands with no parameters. Removed unused test code. Removed unused execution parameter constant.
GDYendell
approved these changes
Oct 9, 2024
This was referenced Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the core code for supporting commands withinFrameProcessor plugins.
No commands are implemented within this PR.
Fixes #352