Deprecate a..b based ranges in favour of ..=

odin-lang · Jun 1, 2022 · ba5f7c4 · ba5f7c4
1 parent 487bd3d
commit ba5f7c4
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/core/encoding/entity/entity.odin b/core/encoding/entity/entity.odin
@@ -231,16 +231,16 @@ xml_decode_entity :: proc(entity: string) -> (decoded: rune, ok: bool) {
 		for len(entity) > 0 {
 			r := entity[0]
 			switch r {
-			case '0'..'9':
+			case '0'..='9':
 				val *= base
 				val += int(r - '0')
 
-			case 'a'..'f':
+			case 'a'..='f':
 				if base == 10 { return -1, false }
 				val *= base
 				val += int(r - 'a' + 10)
 
-			case 'A'..'F':
+			case 'A'..='F':
 				if base == 10 { return -1, false }
 				val *= base
 				val += int(r - 'A' + 10)

diff --git a/core/encoding/xml/tokenizer.odin b/core/encoding/xml/tokenizer.odin
@@ -198,7 +198,7 @@ is_valid_identifier_rune :: proc(r: rune) -> bool {
 		switch r {
 		case '_', '-', ':':        return true
 		case 'A'..='Z', 'a'..='z': return true
-		case '0'..'9':             return true
+		case '0'..='9':            return true
 		case -1:                   return false
 		}
 	}

diff --git a/src/parser.cpp b/src/parser.cpp
@@ -1428,6 +1428,7 @@ Token expect_operator(AstFile *f) {
 		             LIT(p));
 	}
 	if (f->curr_token.kind == Token_Ellipsis) {
+		syntax_warning(f->curr_token, "'..' for ranges has now be deprecated, prefer '..='");
 		f->tokens[f->curr_token_index].flags |= TokenFlag_Replace;
 	}