Linux POSIX support #4118
Linux POSIX support #4118
Conversation
Co-authored-by: Feoramund <161657516+Feoramund@users.noreply.github.com>
|
Also, are you planning on keeping this PR going or should we merge this and do other PRs for the rest? |
|
@laytan Now that I have a better idea of the work to be done, 'll keep this PR going (unless I find a change that's so massive it would be saner if it had its own PR). |
- fnmatch - grp - langinfo - locale
No need for the enum runtime checks. Constant values were set manually and comments were added to help locate their origin.
…pport for netinet/in.
|
@laytan As I get experience writing these POSIX implementations, I realize there is a lot of work still to be done. This PR became very, very big. I'd like to consider it ready for review for what it implements. I'll create smaller PRs with another chunk of POSIX implementations after this is fully reviewed, approved, and merged. Those future PRs be smaller, with 1-3 files in I think this way can keep these PRs saner for everyone, but I'm open to the opinion of reviewers. |
|
@andradei instead of putting review comments everywhere and taking the time to explain every little thing and having you then make the changes I opted to just commit my reviews/corrections/cleanups here directly. Let me know about any questions regarding the changes. I will merge this once those questions have been answered/if you got no questions. Still need to do a couple headers I see and then we can also enable the tests etc. I see from your last comment that you are picking those up in separate PRs which is fine by me. |
|
@laytan I left questions on your commit. Thank you for reviewing this. |
Add the missing Linux-specific support for many POSIX headers.