Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[os2/process]: Don't quote arguments unless needed #4272

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

flysand7
Copy link
Contributor

This PR makes os2.process_start avoid quoting command line arguments, unless they are quoted. The information about which characters need to be quoted is taken from cmd/? help, but also space and a quote is added.

This fixed the behavior of running "cmd.exe" "/c" "<command>", where if /c flag is quoted, the cmd would refuse to understand the location of the command (Don't ask me I have no idea why that's a thing)

C:\Users\flysand7\raven>"cmd" /c "odin test" 
odin is a tool for managing Odin source code.
[...]

C:\Users\flysand7\raven>"cmd" "/c" "odin test" 
'"odin test' is not recognized as an internal or external command,
operable program or batch file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant