[ADD] purchase: import vendor pricelist #11047
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Felicious
force-pushed
the
17.0-purchase-vendor-pricelist-feku
branch
from
7cde2c3
to
109b35f
Compare
|
Hello @kekiss ! This import PR is ready for your first round of peer review. This is your scope, so feel free to leave many comments~ 😊 I'm open to any and all feedback, particularly structure. If you think there's a better way to reorganize any of this info, feel free to share 😊 Let's collaborate ❤️ |
|
Received review from @chrp-odoo. While implementing his suggestions, this PR will be converted to draft mode (: |
Felicious
force-pushed
the
17.0-purchase-vendor-pricelist-feku
branch
2 times, most recently
from
e895362
to
9392ac1
Compare
kekiss
approved these changes
Oct 2, 2024
There was a problem hiding this comment.
Great job explaining this information, @Felicious ! I have some small suggestions, but the information and flow are great!
content/applications/inventory_and_mrp/purchase/products/pricelist.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/purchase/products/pricelist.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/purchase/products/pricelist.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/purchase/products/pricelist.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/purchase/products/pricelist.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/purchase/products/pricelist.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/purchase/products/pricelist.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/purchase/products/pricelist.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/purchase/products/pricelist.rst
Outdated
Show resolved
Hide resolved
Felicious
commented
Oct 2, 2024
content/applications/inventory_and_mrp/purchase/products/pricelist.rst
Outdated
Show resolved
Hide resolved
Felicious
commented
Oct 2, 2024
content/applications/inventory_and_mrp/purchase/products/pricelist.rst
Outdated
Show resolved
Hide resolved
Felicious
force-pushed
the
17.0-purchase-vendor-pricelist-feku
branch
from
e09c3e9
to
951b2db
Compare
|
Hello @odoo/us-doc-review ! This PR is ready for final review! |
Felicious
force-pushed
the
17.0-purchase-vendor-pricelist-feku
branch
from
951b2db
to
0bece17
Compare
ksc-odoo
approved these changes
Oct 3, 2024
There was a problem hiding this comment.
@Felicious -- just finished my Final Review. Once you implement the necessary adjustments, feel free to move this to Tech Review.
content/applications/inventory_and_mrp/purchase/products/pricelist.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/purchase/products/pricelist.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/purchase/products/pricelist.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/purchase/products/pricelist.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/purchase/products/pricelist.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/purchase/products/pricelist.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/purchase/products/pricelist.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/purchase/products/pricelist.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/purchase/products/pricelist.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/purchase/products/pricelist.rst
Outdated
Show resolved
Hide resolved
Felicious
force-pushed
the
17.0-purchase-vendor-pricelist-feku
branch
from
cdc3069
to
1f0f21d
Compare
|
Hello @samueljlieber ! This PR is ready for technical review 😄 |
samueljlieber
requested review from
a team
and removed request for
samueljlieber
samueljlieber
approved these changes
Oct 4, 2024
There was a problem hiding this comment.
Hey @Felicious! Nice work on this brand new Purchase doc! Your PR is looking great, approving with a few technical changes and some suggestions for your consideration!
Thank you for your work :)
.....
@robodoo delegate=Felicious
content/applications/inventory_and_mrp/purchase/products/pricelist.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/purchase/products/pricelist.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/purchase/products/pricelist.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/purchase/products/pricelist.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/purchase/products/pricelist.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/purchase/products/pricelist.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/purchase/products/pricelist.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/purchase/products/pricelist.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/purchase/products/pricelist.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/purchase/products/pricelist.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: kekiss <karaekiss@yahoo.com> Co-authored-by: ksc-odoo <73958186+ksc-odoo@users.noreply.github.com> Co-authored-by: Sam Lieber (sali) <36018073+samueljlieber@users.noreply.github.com>
Felicious
force-pushed
the
17.0-purchase-vendor-pricelist-feku
branch
from
7b5bc7f
to
a7c8f7e
Compare
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Oct 4, 2024
closes #11047 Signed-off-by: Felicia Kuan (feku) <feku@odoo.com> Co-authored-by: kekiss <karaekiss@yahoo.com> Co-authored-by: ksc-odoo <73958186+ksc-odoo@users.noreply.github.com> Co-authored-by: Sam Lieber (sali) <36018073+samueljlieber@users.noreply.github.com>
This was referenced Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New doc on formatting and importing vendor pricelists in bulk.
Received help from import/export expert, @chrp-odoo
Task
FWport: yes :D