Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] Appraisals: Skills Report - highest improvement #11112

Conversation

larm-odoo
Copy link
Contributor

@larm-odoo larm-odoo commented Sep 26, 2024

There's a new feature in the Skills Reporting in Odoo Online, where you can determine the employee with the highest improvement levels for their skills. Adding this use case to Odoo Online and Master.​

The only change is the new section at the bottom.

Original project task card for this PR.

@robodoo
Copy link
Collaborator

robodoo commented Sep 26, 2024

Pull request status dashboard

@C3POdoo C3POdoo requested a review from a team September 26, 2024 15:14
@larm-odoo
Copy link
Contributor Author

Hi @Felicious - this is ready for a first-round review!

Copy link
Contributor

@Felicious Felicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing job adding this use case, @larm-odoo (:
I just had one super small suggestion, and that's it 😊

@larm-odoo larm-odoo force-pushed the saas-17.4-appraisals-adding-skills-report-use-case branch from b6476d9 to e4fb884 Compare September 30, 2024 20:25
@larm-odoo larm-odoo requested a review from a team September 30, 2024 20:25
@larm-odoo
Copy link
Contributor Author

Hi @ksc-odoo - this is ready for a final review! Just added the new section on the bottom, which was added in 17.4.

Copy link
Contributor

@ksc-odoo ksc-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @larm-odoo -- just gave this a Final Review. Nice, clean content. Only have one minor comment. Once you implement the necessary adjustments, feel free to tag this for tech review.

content/applications/hr/appraisals/skills_evolution.rst Outdated Show resolved Hide resolved
@larm-odoo larm-odoo force-pushed the saas-17.4-appraisals-adding-skills-report-use-case branch from e4fb884 to a9a5194 Compare October 1, 2024 20:38
@larm-odoo larm-odoo requested a review from a team October 1, 2024 21:02
@larm-odoo
Copy link
Contributor Author

Hi @samueljlieber - this is ready for a tech review!

Copy link
Contributor

@samueljlieber samueljlieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @larm-odoo, thank you for your work! Approving with two quick fixes :)
...
@robodoo delegate=larm-odoo

content/applications/hr/appraisals/skills_evolution.rst Outdated Show resolved Hide resolved
content/applications/hr/appraisals/skills_evolution.rst Outdated Show resolved Hide resolved
@samueljlieber samueljlieber added the 3 label Oct 4, 2024
@larm-odoo larm-odoo force-pushed the saas-17.4-appraisals-adding-skills-report-use-case branch from a9a5194 to c151368 Compare October 4, 2024 17:11
@larm-odoo
Copy link
Contributor Author

@robodoo r+

robodoo pushed a commit that referenced this pull request Oct 4, 2024
closes #11112

Signed-off-by: Lara Martini (larm) <larm@odoo.com>
@robodoo robodoo closed this Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants