Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Default value when no value found #1377

Open
wants to merge 2 commits into
base: 8.0
Choose a base branch
from
Open

Conversation

diggy128
Copy link

@diggy128 diggy128 commented Jun 8, 2017

Default value should be set to Empty record instead of False for
Many2one fields when no value is to be set.
See: odoo/odoo#4384

@anajuaristi
Copy link
Contributor

Hi @diggy128. Thank you for your contribution.

@oihane @Daniel-CA
Could you please review this PR? I'm not sure it's correct since add middle staff should not show any value but let user to select the product he wants from full catalogue.

Please let me know

@oihane
Copy link
Contributor

oihane commented Jun 9, 2017

@diggy128 can you please rebase this PR?

Thanks for your contribution, let's see if the travis fixes.

@Daniel-CA
Copy link
Member

👍 LGTM, waiting for rebase.

@codecov-io
Copy link

codecov-io commented Jun 16, 2017

Codecov Report

Merging #1377 into 8.0 will decrease coverage by 14.3%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              8.0   #1377       +/-   ##
==========================================
- Coverage   61.71%   47.4%   -14.31%     
==========================================
  Files         284      25      -259     
  Lines        8556     791     -7765     
==========================================
- Hits         5280     375     -4905     
+ Misses       3276     416     -2860
Impacted Files Coverage Δ
...lity_control_between_dates/models/qc_inspection.py 31.25% <0%> (-68.75%) ⬇️
quality_control_mrp_operations/models/mrp.py 31.11% <0%> (-63.34%) ⬇️
quality_control_samples/models/qc_inspection.py 42.85% <0%> (-52.39%) ⬇️
quality_control_version/hooks.py 50% <0%> (-50%) ⬇️
quality_control_version/models/qc_test.py 43.33% <0%> (-36.67%) ⬇️
quality_control_tolerance/models/qc_inspection.py 35% <0%> (-27.5%) ⬇️
quality_control_samples/models/qc_sample.py 63.33% <0%> (-26.67%) ⬇️
quality_control_between_dates/models/qc_test.py 39.13% <0%> (-26.09%) ⬇️
quality_control_hr/models/qc_inspection.py 83.33% <0%> (-16.67%) ⬇️
quality_control_tolerance/models/qc_test.py 50% <0%> (-14.07%) ⬇️
... and 258 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bb421a...6582e1a. Read the comment docs.

Default value should be set to Empty record instead of False for
Many2one fields when no value is to be set.
See: odoo/odoo#4384
@diggy128 diggy128 reopened this Jun 16, 2017
@diggy128
Copy link
Author

Sorry for the mess. my zenbook's touchpad is freaking out and pissing me off.
Should be OK now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants