Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event mapper payload consistency #96

Open
cmgrote opened this issue Oct 21, 2019 · 1 comment
Open

Event mapper payload consistency #96

cmgrote opened this issue Oct 21, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@cmgrote
Copy link
Member

cmgrote commented Oct 21, 2019

On testing the event mapper bugs in #17 a number of different times it seems that the payloads that are generated are not consistent. In particular, sometimes certain objects are identified as having changed (typically around data_file_records and their contained data_file_fields) and other times not. When it did appear, it looked like it was to do with the items array of relationship properties being ordered differently: or at last being detected as being ordered differently.

Needs deeper investigation: have added thorough debug logging to output the diffs that are calculated and the full source and target objects that were diff'd. Next step is to reproduce the problematic diffs (with debug logging on) to see whether the problem appears to be from:

  • different items array ordering from IGC from one query to another (within a relationship property, so sorting cannot be applied)
  • spurious JsonDiff results despite the compared objects actually having the same array ordering
  • something else?

The issue is that the diffs being generated include either replace or remove ops, causing DELETE_PURGED_RELATIONSHIP_EVENTs to be triggered -- and in many cases the last event raised for a given relationship is this DELETE_PURGED_RELATIONSHIP_EVENT which would mean the relationship is entirely removed from the cohort (never replaced with a NEW_RELATIONSHIP_EVENT).

@cmgrote cmgrote added the bug Something isn't working label Oct 21, 2019
@cmgrote cmgrote self-assigned this Oct 21, 2019
@cmgrote cmgrote added this to the 1.3 milestone Dec 5, 2019
@cmgrote cmgrote modified the milestones: 1.3, 1.4 Jan 2, 2020
@cmgrote cmgrote modified the milestones: 1.4, 1.5 Feb 5, 2020
@cmgrote cmgrote removed this from the 1.6 milestone Apr 2, 2020
@cmgrote cmgrote removed their assignment Aug 13, 2020
@cmgrote cmgrote added enhancement New feature or request and removed bug Something isn't working labels Feb 9, 2021
@cmgrote
Copy link
Member Author

cmgrote commented Feb 9, 2021

Parking as an enhancement, as unlikely the event mapper will be reinstated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant