Operator development update: config files now loading #37
Conversation
planetf1
commented
Apr 29, 2022
planetf1
commented
- Removed security connector definitions from sample configs (see Operator should always be able to start servers configured #36)
- Config documents mounted from configmaps into /deployments/shadowdata
- New init container to copy into /deployments/data as egeria needs to write to them (a. if using secure connector b. always, unless passed as part of server start)
- Additional debug support
- Debug Logs
- Disable autostart (so container can be inspected)
Signed-off-by: Nigel Jones <nigel.l.jones+git@gmail.com>
…ugging) Signed-off-by: Nigel Jones <nigel.l.jones+git@gmail.com>
…EBUG whilst in dev Signed-off-by: Nigel Jones <nigel.l.jones+git@gmail.com>
Signed-off-by: Nigel Jones <nigel.l.jones+git@gmail.com>
Signed-off-by: Nigel Jones <nigel.l.jones+git@gmail.com>
Signed-off-by: Nigel Jones <nigel.l.jones+git@gmail.com>
Signed-off-by: Nigel Jones <nigel.l.jones+git@gmail.com>
Signed-off-by: Nigel Jones <nigel.l.jones+git@gmail.com>
Signed-off-by: Nigel Jones <nigel.l.jones+git@gmail.com>
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
| @@ -1,9 +1,17 @@ | |||
| #!/bin/sh | |||
| #!/bin/zsh | |||
There was a problem hiding this comment.
ShellCheck: ShellCheck only supports sh/bash/dash/ksh scripts. Sorry!
(at-me in a reply with help or ignore)
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| //autostart["STARTUP_SERVER_LIST"] = "cocoMDS4, cocoMDS1, cocoView1" | ||
| autostart["STARTUP_SERVER_LIST"], _ = reconciler.getServersFromConfigMap(ctx, egeriaInstance) | ||
|
|
||
| if egeriaInstance.Spec.Autostart == true { |
There was a problem hiding this comment.
S1002: should omit comparison to bool constant, can be simplified to egeriaInstance.Spec.Autostart
(at-me in a reply with help or ignore)
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| //autostart["STARTUP_SERVER_LIST"] = "cocoMDS4, cocoMDS1, cocoView1" | ||
| autostart["STARTUP_SERVER_LIST"], _ = reconciler.getServersFromConfigMap(ctx, egeriaInstance) | ||
|
|
||
| if egeriaInstance.Spec.Autostart == true { |
There was a problem hiding this comment.
gosimple: S1002: should omit comparison to bool constant, can be simplified to egeriaInstance.Spec.Autostart
(at-me in a reply with help or ignore)
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| @@ -1,9 +1,17 @@ | |||
| #!/bin/sh | |||
| #!/bin/zsh | |||
There was a problem hiding this comment.
ShellCheck: ShellCheck only supports sh/bash/dash/ksh scripts. Sorry!
(at-me in a reply with help or ignore)
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| //autostart["STARTUP_SERVER_LIST"] = "cocoMDS4, cocoMDS1, cocoView1" | ||
| autostart["STARTUP_SERVER_LIST"], _ = reconciler.getServersFromConfigMap(ctx, egeriaInstance) | ||
|
|
||
| if egeriaInstance.Spec.Autostart == true { |
There was a problem hiding this comment.
S1002: should omit comparison to bool constant, can be simplified to egeriaInstance.Spec.Autostart
(at-me in a reply with help or ignore)
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| //autostart["STARTUP_SERVER_LIST"] = "cocoMDS4, cocoMDS1, cocoView1" | ||
| autostart["STARTUP_SERVER_LIST"], _ = reconciler.getServersFromConfigMap(ctx, egeriaInstance) | ||
|
|
||
| if egeriaInstance.Spec.Autostart == true { |
There was a problem hiding this comment.
gosimple: S1002: should omit comparison to bool constant, can be simplified to egeriaInstance.Spec.Autostart
(at-me in a reply with help or ignore)
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
